Change in vdsm[master]: Added glusterVolumeProfileStart verb

Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/7285

to review the following change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................

Added glusterVolumeProfileStart verb

Change-Id: I279977bb4dc3631162ce22668612103896646afe
Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com&gt;
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
4 files changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/7285/1

diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 576ddf1..47e5675 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -221,6 +221,10 @@
         """
         return {'hosts': self.svdsmProxy.glusterPeerStatus()}
 
+    @exportAsVerb
+    def volumeProfileStart(self, volumeName):
+        self.svdsmProxy.glusterVolumeProfileStart(volumeName)
+
 
 def getGlusterMethods(gluster):
     l = []
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index dd79865..5956bbc 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -543,3 +543,13 @@
     else:
         return _parsePeerStatus(out, _getGlusterHostName(),
                                 _getGlusterUuid(), HostStatus.CONNECTED)
+
+
+@exportToSuperVdsm
+def volumeProfileStart(volumeName):
+    command = _getGlusterVolCmd() + ["profile", volumeName, "start"]
+    rc, out, err = _execGluster(command)
+    if rc:
+        raise ge.GlusterVolumeProfileStartFailedException(rc, out, err)
+    else:
+        return True
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 8d48c48..d2ebc1e 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -347,3 +347,8 @@
 class GlusterHostListFailedException(GlusterHostException):
     code = 4407
     message = "Host list failed"
+
+
+class GlusterVolumeProfileStartFailedException(GlusterVolumeException):
+    code = 4408
+    message = "Volume profile start failed"
diff --git a/vdsm_cli/vdsClientGluster.py b/vdsm_cli/vdsClientGluster.py
index e72c424..1f5d52a 100644
--- a/vdsm_cli/vdsClientGluster.py
+++ b/vdsm_cli/vdsClientGluster.py
@@ -199,6 +199,10 @@
         pp.pprint(status)
         return status['status']['code'],
status['status']['message']
 
+    def do_glusterVolumeProfileStart(self, args):
+        status = self.s.glusterVolumeProfileStart(args[0])
+        return status['status']['code'],
status['status']['message']
+
 
 def getGlusterCmdDict(serv):
     return {
@@ -355,4 +359,9 @@
              ('',
               'list host info'
               )),
+        'glusterVolumeProfileStart':
+            (serv.do_glusterVolumeProfileStart,
+             ('<volume_name>\n\t<volume_name> is existing volume
name',
+              'start gluster volume profile'
+              )),
         }


--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Added glusterVolumeProfileStart verb

Change-Id: I279977bb4dc3631162ce22668612103896646afe
Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com&gt;
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
4 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Bala.FA: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 9: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Bala.FA has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 9: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/724/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/631/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/560/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Timothy Asir has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/gluster/api.py
Line 221:         """
Line 222:         return {'hosts': self.svdsmProxy.glusterPeerStatus()}
Line 223: 
Line 224:     @exportAsVerb
Line 225:     def volumeProfileStart(self, volumeName):
Done
Line 226:         self.svdsmProxy.glusterVolumeProfileStart(volumeName)
Line 227: 
Line 228: 
Line 229: def getGlusterMethods(gluster):


....................................................
File vdsm/gluster/cli.py
Line 546: 
Line 547: 
Line 548: @exportToSuperVdsm
Line 549: def volumeProfileStart(volumeName):
Line 550:     command = _getGlusterVolCmd() + ["profile", volumeName,
"start"]
Done
Line 551:     rc, out, err = _execGluster(command)
Line 552:     if rc:
Line 553:         raise ge.GlusterVolumeProfileStartFailedException(rc, out, err)
Line 554:     else:


--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Bala.FA has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/gluster/api.py
Line 221:         """
Line 222:         return {'hosts': self.svdsmProxy.glusterPeerStatus()}
Line 223: 
Line 224:     @exportAsVerb
Line 225:     def volumeProfileStart(self, volumeName):
Add options=None for future use
Line 226:         self.svdsmProxy.glusterVolumeProfileStart(volumeName)
Line 227: 
Line 228: 
Line 229: def getGlusterMethods(gluster):


....................................................
File vdsm/gluster/cli.py
Line 546: 
Line 547: 
Line 548: @exportToSuperVdsm
Line 549: def volumeProfileStart(volumeName):
Line 550:     command = _getGlusterVolCmd() + ["profile", volumeName,
"start"]
Use --xml, if available
Line 551:     rc, out, err = _execGluster(command)
Line 552:     if rc:
Line 553:         raise ge.GlusterVolumeProfileStartFailedException(rc, out, err)
Line 554:     else:


--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterVolumeProfileStart verb
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/490/ : ABORTED

--
To view, visit http://gerrit.ovirt.org/7285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server