Change in vdsm[master]: supervdsm: log actual error in ProxyCaller

Saggi Mizrahi has uploaded a new change for review.

Change subject: supervdsm: log actual error in ProxyCaller
......................................................................

supervdsm: log actual error in ProxyCaller

Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
---
M vdsm/supervdsm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/35475/1

diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py
index d6b0209..46247f2 100644
--- a/vdsm/supervdsm.py
+++ b/vdsm/supervdsm.py
@@ -37,6 +37,7 @@
 
 
 class ProxyCaller(object):
+    log = logging.getLogger("supervdsm.ProxyCaller")
 
     def __init__(self, supervdsmProxy, funcName):
         self._funcName = funcName
@@ -50,6 +51,7 @@
             return callMethod()
         except RemoteError:
             self._supervdsmProxy._connect()
+            self.log.exception("Could not call method")
             raise RuntimeError(
                 "Broken communication with supervdsm. Failed call to %s"
                 % self._funcName)


-- 
To view, visit http://gerrit.ovirt.org/35475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: log actual error in ProxyCaller
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35475/1/vdsm/supervdsm.py
File vdsm/supervdsm.py:

Line 53:             self._supervdsmProxy._connect()
Line 54:             self.log.exception("Could not call method")
Line 55:             raise RuntimeError(
Line 56:                 "Broken communication with supervdsm. Failed call to
%s"
Line 57:                 % self._funcName)
you should see this exception and this should be enough... I don't understand the
reason for that patch
Line 58: 
Line 59: 
Line 60: class SuperVdsmProxy(object):
Line 61:     """


-- 
To view, visit http://gerrit.ovirt.org/35475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: supervdsm: log actual error in ProxyCaller
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12793/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13745/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_infra_functional_tests_gerrit/22/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13582/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/35475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Piotr Kliczewski]

Piotr Kliczewski has abandoned this change.

Change subject: supervdsm: log actual error in ProxyCaller
......................................................................


Abandoned

Yaniv has a point so abandoning this patch.

-- 
To view, visit https://gerrit.ovirt.org/35475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: supervdsm: log actual error in ProxyCaller
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/35475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a1c83d2a963002d3c793398bb62679b77f5f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No