Change in vdsm[master]: vdsm-reg-setup: read more then one URI

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm-reg-setup: read more then one URI
......................................................................

vdsm-reg-setup: read more then one URI

To help backward compatibility, now is possible to read more then
one URI from /etc/vdsm-reg/vdsm-reg.conf, just use the caracter ',' to
separate each URI.

Example:
vdc_reg_uri=/OvirtEngineWeb/register,/RHEVManagerWeb/VdsAutoRegistration.aspx

Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm_reg/vdsm-reg-setup.in
1 file changed, 46 insertions(+), 39 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/3739/1
--
To view, visit http://gerrit.ovirt.org/3739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg-setup: read more then one URI
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg-setup: read more then one URI
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 14: vdc_reg_uri=/OvirtEngineWeb/register,/RHEVManagerWeb/VdsAutoRegistration.aspx
do we really want upstream node registering to downstream engine out-of-the box?

the original code is messy, and this patch increases its complexity. I am not sure this is worth while.

--
To view, visit http://gerrit.ovirt.org/3739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg-setup: read more then one URI
......................................................................

Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 14: vdc_reg_uri=/OvirtEngineWeb/register,/RHEVManagerWeb/VdsAutoRegistration.aspx
It's not registering to downstream out of box. It's just a feature that can be used in the future if needed (try to register more then 1 uri). I just wrote the above uri as example but I am ok if we do not add this feature upstream. Thanks!

--
To view, visit http://gerrit.ovirt.org/3739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has abandoned this change.

Change subject: vdsm-reg-setup: read more then one URI
......................................................................

Patch Set 1: Abandoned

We do not require such change in upstream.

--
To view, visit http://gerrit.ovirt.org/3739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id367b8a0cb9f28369d353122640ebaa4ecc913c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf