Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: isolate fake_kvm into a hook ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
partial "review". actually, it's only a glimpse.
https://gerrit.ovirt.org/#/c/46897/4/vdsm/caps.py File vdsm/caps.py:
Line 217: archTag = guestTag.find('arch') Line 218: if archTag.get('name') == arch: Line 219: return _findLiveSnapshotSupport(guestTag) Line 220: Line 221: logging.error("missing guest arch tag in the capabilities XML") does not seem intentional; at least I don't see the motivation of adding this log always. Line 222: Line 223: return None Line 224: Line 225:
vdsm-patches@lists.fedorahosted.org