Change in vdsm[master]: Remove redundant vlan device deletion.

Antoni Segura Puimedon has uploaded a new change for review.

Change subject: Remove redundant vlan device deletion.
......................................................................

Remove redundant vlan device deletion.

ifdown-eth has a clause that on ifdown of a vlan interface, said
interface is deleted using ip link delete xxx type vlan. That
happens synchronously and just one line before we do the deletion
ourselves and generates a lot of FAILED messages in vdsm.log.

Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Signed-off-by: Antoni S. Puimedon 
---
M vdsm/configNetwork.py
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/10008/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index e6daa68..711a0d4 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -558,7 +558,6 @@
     def removeVlan(self, vlan, iface):
         vlandev = iface + '.' + vlan
         ifdown(vlandev)
-        execCmd([constants.EXT_IPROUTE, 'link', 'del', vlandev])
         self._backup(self.NET_CONF_PREF + iface + '.' + vlan)
         self._removeFile(self.NET_CONF_PREF + iface + '.' + vlan)

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/346/ (2/2)

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/312/ (1/2)

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/312/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/346/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1: Looks good to me, approved

gosh, this is old. this line has originally been added to circumvent initscripts bug https://bugzilla.redhat.com/show_bug.cgi?id=481557 "ifdown of vlan iface which is a bridge member, does not take vlan iface down"

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: Remove redundant vlan device deletion.
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove redundant vlan device deletion.
......................................................................

Remove redundant vlan device deletion.

ifdown-eth has a clause that on ifdown of a vlan interface, said
interface is deleted using ip link delete xxx type vlan. That
happens synchronously and just one line before we do the deletion
ourselves and generates a lot of FAILED messages in vdsm.log.

Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Signed-off-by: Antoni S. Puimedon 
---
M vdsm/configNetwork.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Mark Wu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server