4:12 a.m.
Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/12959
to review the following change.
Change subject: bootstrap: remove glusterfs packages
......................................................................
bootstrap: remove glusterfs packages
As glusterfs packages are dependencies for vdsm-gluster package,
having these in bootstrap is redundant
Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/12959/1
diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py
index 61e0f6f..219e6e4 100755
--- a/vds_bootstrap/vds_bootstrap.py
+++ b/vds_bootstrap/vds_bootstrap.py
@@ -159,8 +159,7 @@
'seabios', 'qemu-img', 'fence-agents',
'libselinux-python', 'sanlock',
'sanlock-python')
# Gluster packages
- GLUSTER_PACK = ('vdsm-gluster', 'glusterfs-server',
'glusterfs-rdma',
- 'glusterfs-geo-replication')
+ GLUSTER_PACK = (VDSM_NAME + '-gluster', )
else:
# Devel packages
DEVEL_PACK = ('gdb', 'tcpdump', 'strace', 'ltrace',
'sysstat', 'ntp',
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0aad124..1cb189e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -402,7 +402,10 @@
BuildArch: noarch
Requires: %{name} = %{version}-%{release}
-Requires: glusterfs glusterfs-server glusterfs-fuse
+Requires: glusterfs
+Requires: glusterfs-server
+Requires: glusterfs-fuse
+Requires: glusterfs-rdma
%description gluster
Gluster plugin enables VDSM to serve Gluster functionalities.
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
9:04 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: remove glusterfs packages
......................................................................
bootstrap: remove glusterfs packages
As glusterfs packages are dependencies for vdsm-gluster package,
having these in bootstrap is redundant
Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Timothy Asir: Looks good to me, but someone else must approve
Bala.FA: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
12:31 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: remove glusterfs packages
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
6:54 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: remove glusterfs packages
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4:46 a.m.
Timothy Asir has posted comments on this change.
Change subject: bootstrap: remove glusterfs packages
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4:36 a.m.
Bala.FA has posted comments on this change.
Change subject: bootstrap: remove glusterfs packages
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde338599155df43af3a0fd0d14a02e3bddda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4098
days inactive
4099
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
barumuga＠redhat.com -
Dan Kenigsberg -
Douglas Schilling Landgraf -
tjeyasin＠redhat.com