Change in vdsm[master]: libvirtd.log: time to be less verbose

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: libvirtd.log: time to be less verbose
......................................................................

libvirtd.log: time to be less verbose

After several years, we can drop log verbosity to libvirt's default.
Currently, libvirt logs are filling up ovirt-nodes that run dozens of
VMs.

Change-Id: I251c2534d3284aa95bffa56143c449d5de887008
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 9 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/31135/1

diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 8136613..636babf 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -349,7 +349,7 @@
     # version != PACKAGE_VERSION since we do not want to update configuration
     # on every update. see 'configuration versioning:' at Configfile.py for
     # details.
-    CONF_VERSION = '4.13.0'
+    CONF_VERSION = '4.17.0'

PKI_DIR = os.path.join(SYSCONF_PATH, 'pki/vdsm')
     CA_FILE = os.path.join(PKI_DIR, 'certs/cacert.pem')
@@ -388,14 +388,6 @@
                         'auth_unix_rw': '"sasl"',
                         'host_uuid': '"' + str(uuid.uuid4()) + '"',
                         'keepalive_interval': -1,
-                        # FIXME until we are confident with libvirt
-                        #  integration, let us have a verbose log
-                        'log_outputs': (
-                            '"1:file:/var/log/libvirt/libvirtd.log"'),
-                        'log_filters': (
-                            '"3:virobject 3:virfile 2:virnetlink '
-                            '3:cgroup 3:event 3:json 1:libvirt '
-                            '1:util 1:qemu"'),
                     },
                 },
                 {

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10690/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11632/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11475/ : SUCCESS

mooli tayer has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1: Code-Review+1

mooli tayer has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1:

http://libvirt.org/logging.html

If I understand correctly this will log warnings and errors to:
0.10.0 or later: systemd journal
0.9.0 or later: file /var/log/libvirt/libvirtd.log

Michal Skrivanek has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1: Code-Review+1

well, i believe the sacrifice is worth it

Francesco Romani has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1: Code-Review+1

like the idea

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1:

would someone be my guess to also verify that ...?

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10748/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11690/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11533/ : SUCCESS

Michal Skrivanek has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2:

pardon my ignorance of the code - does it modify existing installs?

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 1:

yes, after upgrading vdsm to version that includes that change, vdsm will restart libvirt service and this conf will take over

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2:

if i understand the question correctly..

Michal Skrivanek has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2:

yes, thank you.

Francesco Romani has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

Still like the idea, but I believe we can discuss some tuning.

-1 only for visibility

http://gerrit.ovirt.org/#/c/31135/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 390
Line 391
Line 392
Line 393
Line 394
what about just changing to

'log_outputs': (
   '"3:file:/var/log/libvirt/libvirtd.log"'),

this will severly reduce the log pressure but will preserve the log file, which I like to have.

Line 394
Line 395
Line 396
Line 397
Line 398
OK with deleting this to reduce the noise

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31135/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 390
Line 391
Line 392
Line 393
Line 394
> what about just changing to

afaiu the default value for log_outputs points to this path. so leaving that won't change much

(from http://libvirt.org/logging.html - ""0.9.0 or later: file /var/log/libvirt/libvirtd.log if running as a daemon"")

Francesco Romani has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31135/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 390
Line 391
Line 392
Line 393
Line 394
> afaiu the default value for log_outputs points to this path. so leaving tha

Right, this is the default setting already. Then I'm just fine with the patch.

mooli tayer has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 3:

Rebased

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11220/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12162/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12009/ : SUCCESS

mooli tayer has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 3: Verified+1

Tested this on el6.5.

installation & vdsm-tool with no problems.

After runnnig a vm playing with it a little bit and 
taking it down all I can see in 
/var/log/libvirt/libvirtd.log is a few errors and infos:

2014-08-31 11:19:07.312+0000: 12010: info : libvirt version: 0.10.2, package: 29.el6_5.11 (Red Hat, Inc. http://bugzilla.redhat.com/bugzilla, 2014-07-22-03:44:21, x86-029.build.eng.bos.redhat.com)
2014-08-31 11:19:07.312+0000: 12010: error : virNWFilterSnoopLeaseFileRefresh:1903 : open("/var/run/libvirt/network/nwfilter.ltmp"): No such file or directory
2014-08-31 11:44:50.660+0000: 3252: info : libvirt version: 0.10.2, package: 29.el6_5.11 (Red Hat, Inc. http://bugzilla.redhat.com/bugzilla, 2014-07-22-03:44:21, x86-029.build.eng.bos.redhat.com)
2014-08-31 11:44:50.660+0000: 3252: error : virNWFilterSnoopLeaseFileRefresh:1903 : open("/var/run/libvirt/network/nwfilter.ltmp"): No such file or directory
[root@dhcp-0-214 RPMS]# less  /var/log/libvirt/libvirtd.log 
[root@dhcp-0-214 RPMS]# cat  /var/log/libvirt/libvirtd.log 
2014-08-31 11:19:07.312+0000: 12010: info : libvirt version: 0.10.2, package: 29.el6_5.11 (Red Hat, Inc. http://bugzilla.redhat.com/bugzilla, 2014-07-22-03:44:21, x86-029.build.eng.bos.redhat.com)
2014-08-31 11:19:07.312+0000: 12010: error : virNWFilterSnoopLeaseFileRefresh:1903 : open("/var/run/libvirt/network/nwfilter.ltmp"): No such file or directory
2014-08-31 11:44:50.660+0000: 3252: info : libvirt version: 0.10.2, package: 29.el6_5.11 (Red Hat, Inc. http://bugzilla.redhat.com/bugzilla, 2014-07-22-03:44:21, x86-029.build.eng.bos.redhat.com)
2014-08-31 11:44:50.660+0000: 3252: error : virNWFilterSnoopLeaseFileRefresh:1903 : open("/var/run/libvirt/network/nwfilter.ltmp"): No such file or directory

Francesco Romani has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 3: Code-Review+1

the libvirt defaults should be good enough for virt.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 3: Code-Review+2

If it's good for virt, it's good for me.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: libvirtd.log: time to be less verbose
......................................................................

libvirtd.log: time to be less verbose

After several years, we can drop log verbosity to libvirt's default.
Currently, libvirt logs are filling up ovirt-nodes that run dozens of
VMs.

Change-Id: I251c2534d3284aa95bffa56143c449d5de887008
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125237
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/31135
Tested-by: mooli tayer 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  mooli tayer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtd.log: time to be less verbose
......................................................................

Patch Set 4:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5767/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/132/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3926/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1791/ : FAILURE