Change in vdsm[master]: PEP8 fixes for nfsSD

[Ryan Harper]

Ryan Harper has uploaded a new change for review.

Change subject: PEP8 fixes for nfsSD
......................................................................

PEP8 fixes for nfsSD

pep8 complaints:

vdsm/storage/nfsSD.py:16:80: E501 line too long (80 characters)
vdsm/storage/nfsSD.py:33:1: E302 expected 2 blank lines, found 1
vdsm/storage/nfsSD.py:54:80: E501 line too long (84 characters)
vdsm/storage/nfsSD.py:97:80: E501 line too long (82 characters)
vdsm/storage/nfsSD.py:111:37: E225 missing whitespace around operator
vdsm/storage/nfsSD.py:114:28: E231 missing whitespace after ':'
vdsm/storage/nfsSD.py:115:80: E501 line too long (87 characters)
vdsm/storage/nfsSD.py:137:5: E303 too many blank lines (2)
vdsm/storage/nfsSD.py:153:1: W391 blank line at end of file

Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Signed-off-by: Ryan Harper 
---
M vdsm/storage/nfsSD.py
1 file changed, 11 insertions(+), 8 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/3936/1
--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: PEP8 fixes for nfsSD
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Thanks!. Please add the newly-cleaned fine to pep8 whitelist in Makefile.am.

--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Dan Kenigsberg

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: PEP8 fixes for nfsSD
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper

Adam Litke has posted comments on this change.

Change subject: PEP8 fixes for nfsSD
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: PEP8 fixes for nfsSD
......................................................................

Patch Set 2: Verified; Looks good to me, approved

Believing that the verification of http://gerrit.ovirt.org/#change,4478 includes this, ack.

--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: PEP8 fixes for nfsSD
......................................................................

PEP8 fixes for nfsSD

pep8 complaints:

vdsm/storage/nfsSD.py:16:80: E501 line too long (80 characters)
vdsm/storage/nfsSD.py:33:1: E302 expected 2 blank lines, found 1
vdsm/storage/nfsSD.py:54:80: E501 line too long (84 characters)
vdsm/storage/nfsSD.py:97:80: E501 line too long (82 characters)
vdsm/storage/nfsSD.py:111:37: E225 missing whitespace around operator
vdsm/storage/nfsSD.py:114:28: E231 missing whitespace after ':'
vdsm/storage/nfsSD.py:115:80: E501 line too long (87 characters)
vdsm/storage/nfsSD.py:137:5: E303 too many blank lines (2)
vdsm/storage/nfsSD.py:153:1: W391 blank line at end of file

Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Signed-off-by: Ryan Harper 
---
M Makefile.am
M vdsm/storage/nfsSD.py
2 files changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94a06b5eb75795cd30ca50dbfa91bfd883269359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper