Change in vdsm[master]: BZ#840300: setNetworking() return bridge status

Yaniv Bronhaim has uploaded a new change for review.

Change subject: BZ#840300: setNetworking() return bridge status
......................................................................

BZ#840300: setNetworking() return bridge status

As response to http://gerrit.ovirt.org/#/c/6875/1 reviews i understand that this function
must return true.
Because it wasn't so understandable, i edit it to return always true and added related
comment.

Change-Id: I466ad42a05f85636cd4fb9dd3b8aae7362eb6bba
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/6904/1
--
To view, visit http://gerrit.ovirt.org/6904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I466ad42a05f85636cd4fb9dd3b8aae7362eb6bba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Yaniv Bronhaim has abandoned this change.

Change subject: BZ#840300: setNetworking() return bridge status
......................................................................


Patch Set 2: Abandoned

This change is related to patch Change-Id: Idfea98ed31b536699e9d3d6485f5cb62791adcd5

as response to old proposal of bug fix, ill continue to review the original change to
avoid duplication.

--
To view, visit http://gerrit.ovirt.org/6904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I466ad42a05f85636cd4fb9dd3b8aae7362eb6bba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Yaniv Bronhaim has posted comments on this change.

Change subject: BZ#840300: setNetworking() return bridge status
......................................................................


Patch Set 2:

replace the first proposal

--
To view, visit http://gerrit.ovirt.org/6904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I466ad42a05f85636cd4fb9dd3b8aae7362eb6bba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Yair Zaslavsky has posted comments on this change.

Change subject: BZ#840300: setNetworking() return bridge status
......................................................................


Patch Set 2:

General Gerrit question - would you like your patch to be dependant on 
http://gerrit.ovirt.org/#/c/6875/1 or replace its content?

It's not so clear from your commit message.

--
To view, visit http://gerrit.ovirt.org/6904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I466ad42a05f85636cd4fb9dd3b8aae7362eb6bba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;