10:26 a.m.
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/855
commit 00475aaf5591a23cf5c3215dd9c659503bc3d979
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Fri Aug 26 15:16:15 2011 +0000
[WIP] BZ#732980 Handle 4K block size LUN properly
Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index f83316c..c7b3288 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -757,6 +757,7 @@ class HSM:
'devtype': dev.get("devtype", ""),
'pathstatus': dev.get("paths", []),
'pathlist': dev.get("connections", []),
+ 'blocksize': dev.get("blocksize",
""),
'partitioned': partitioned}
for path in devInfo["pathstatus"]:
path["lun"] = path["hbtl"].lun
@@ -838,14 +839,20 @@ class HSM:
knowndevs = list(multipath.getMPDevNamesIter())
devices = []
devSizes = []
+ devBlkSz = set()
for dev in devlist:
if dev in knowndevs:
devices.append(dev)
devSizes.append(multipath.getDeviceSize(devicemapper.getDmId(dev)))
+ devBlkSz.add(multipath.getDeviceBlockSizes(devicemapper.getDmId(dev)))
else:
raise se.InvalidPhysDev(dev)
+ # Block size check
+ if len(devBlkSz) != 1:
+ raise se.VolumeGroupBlockSizeError("VG devices must have the same block
size")
+
#Minimal size check
size = sum(devSizes)
if size < MINIMALVGSIZE:
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 269e0e3..6a026c9 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -226,6 +226,7 @@ def pathListIter(filterGuids=None):
"vendor" : "",
"product" :"",
"fwrev" : "",
+ "blocksize" : "",
}
@@ -252,6 +253,13 @@ def pathListIter(filterGuids=None):
except Exception:
log.warn("Problem getting fwrev from device `%s`", slave,
exc_info=True)
+ if not devInfo["blocksize"]:
+ try:
+ logBlkSize, phyBlkSize = getDeviceBlockSizes(slave)
+ devInfo["blocksize"] = "%i:%i" % (logBlkSize,
phyBlkSize)
+ except Exception:
+ log.warn("Problem getting blocksize from device `%s`",
slave, exc_info=True)
+
pathInfo = {}
pathInfo["physdev"] = slave
pathInfo["state"] = pathStatuses.get(slave, "failed")
diff --git a/vdsm/storage/storage_exception.py b/vdsm/storage/storage_exception.py
index 421737b..2b6c586 100644
--- a/vdsm/storage/storage_exception.py
+++ b/vdsm/storage/storage_exception.py
@@ -999,6 +999,10 @@ class VolumeGroupReplaceTagError(StorageException):
code = 516
message = "Replace Volume Group tag error"
+class VolumeGroupBlockSizeError(StorageException):
+ code = 517
+ message = "Volume Group block size error"
+
class CannotCreateLogicalVolume(StorageException):
code = 550
message = "Cannot create Logical Volume"
10:32 a.m.
New subject: Change in vdsm[master]: [WIP] BZ#732980 Handle 4K block size LUN properly
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] BZ#732980 Handle 4K block size LUN properly
......................................................................
Patch Set 1: (4 inline comments)
Initial implementation. The "create MD areas as multiples of BS" part is still
missing.
....................................................
File vdsm/storage/hsm.py
Line 760: 'blocksize': dev.get("blocksize",
""),
I believe it's nice to communicate this information to RHEVM. It's also useful in
the ruth tests to check that we actually have different block sizes.
See: http://gerrit.usersys.redhat.com/851
....................................................
File vdsm/storage/multipath.py
Line 229: "blocksize" : "",
It's nice to have and communicate this information. See also the comments in the other
files.
Line 259: devInfo["blocksize"] = "%i:%i" %
(logBlkSize, phyBlkSize)
Any objection to this format? We need both values? Feedback is welcome.
....................................................
File vdsm/storage/storage_exception.py
Line 1002: class VolumeGroupBlockSizeError(StorageException):
We should notify this new exception to RHEVM.
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:05 p.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 520: "VG devices block size must be 512")
WRT the error message look at other cases:
$ egrep -r "raise se.[a-zA-Z]+\(['\"]" vdsm
....................................................
File vdsm/storage/hsm.py
Line 858: "All devices in domain must have the same block
size")
WRT the error message look at other cases:
$ egrep -r "raise se.[a-zA-Z]+\(['\"]" vdsm
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:17 a.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 520: "VG devices block size must be 512")
Move text to storage_exception and use
must be any of %s", constants.SUPPORTED_BLOCKSIZES
....................................................
File vdsm/storage/hsm.py
Line 762: 'logicalblocksize':
dev.get("logicalblocksize", ""),
maybe logical_block_size or logicalBlockSize?
Line 858: "All devices in domain must have the same block
size")
Use another error code so mgmt can know the difference
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:18 p.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 762: 'logicalblocksize':
dev.get("logicalblocksize", ""),
Do we really want to change this? the test has been merged using these names. We'll
need to modify the test too. I don't see other camel cased keys here.
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:20 p.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 762: 'logicalblocksize':
dev.get("logicalblocksize", ""),
I take it back, an older version of the test was checking these parameters. We can change
them but still I don't see other camel cased keys here.
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:31 a.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:38 a.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:36 a.m.
New subject: Change in vdsm[master]: BZ#732980 Devices block size must be 512
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
BZ#732980 Devices block size must be 512
Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
---
M vdsm/constants.py.in.in
M vdsm/storage/hsm.py
M vdsm/storage/lvm.py
M vdsm/storage/multipath.py
M vdsm/storage/storage_exception.py
5 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4592
days inactive
4624
days old
vdsm-patches@lists.fedorahosted.org
8 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Federico Simoncelli -
smizrahi＠redhat.com