Change in vdsm[master]: gluster: create pv with custom dataalignment value

Timothy Asir has uploaded a new change for review.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

gluster: create pv with custom dataalignment value

Blivet creates pv with 1mb dataalignment forcefully for
whatever given value. So that we have used vdsm.storage.lvm
module to create pv. But due to some lvm configuration
VDSM also creates pv with 1mb dataalignment value.
Seperate bug oppend for vdsm to fix this issue in
https://bugzilla.redhat.com/show_bug.cgi?id=1235086
This patch uses lvm pvcreate command as a workaround till
this bug fixed in either vdsm or blivet.

Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67
Signed-off-by: Timothy Asir Jeyasingh 
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1178705
---
M vdsm/gluster/storagedev.py
1 file changed, 9 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/42782/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index eb8b103..ec18d19 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -32,7 +32,6 @@
 from blivet.devices import LVMThinLogicalVolumeDevice
 from blivet import udev

-import storage.lvm as lvm
 from vdsm import utils

import fstab
@@ -41,6 +40,9 @@

log = logging.getLogger("Gluster")
+_pvCreateCommandPath = utils.CommandPath("lvcreate",
+                                         "/sbin/pvcreate",
+                                         "/usr/sbin/pvcreate",)
 _vgCreateCommandPath = utils.CommandPath("vgcreate",
                                          "/sbin/vgcreate",
                                          "/usr/sbin/vgcreate",)
@@ -156,9 +158,12 @@
     def _createPV(deviceList, alignment=0):
         def _createAlignedPV(deviceList, alignment):
             for dev in deviceList:
-                rc, out, err = lvm._createpv(
-                    [dev.path], metadataSize=0,
-                    options=('--dataalignment', '%sK' % alignment))
+                # bz#1178705: Blivet always creates pv with 1MB dataalignment
+                # Workaround: Till blivet fixes the issue, we use lvm pvcreate
+                rc, out, err = utils.execCmd([_pvCreateCommandPath.cmd,
+                                              '--dataalignment',
+                                              '%sk' % alignment,
+                                              dev.path])
                 if rc:
                     raise ge.GlusterHostStorageDevicePVCreateFailedException(
                         dev.path, alignment, rc, out, err)

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 1:

* Update tracker::#1178705::OK
* Check Bug-Url::OK
* Check Public Bug::#1178705::OK, public bug
* Check Product::#1178705::SKIPPED, not (oVirt Red Hat Enterprise Virtualization Manager) product but Red Hat Enterprise Linux 7
* Check Product::WARN, no bug url with correct product found, make sure you have at least one bug-url with a product in oVirt Red Hat Enterprise Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Bala.FA has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42782/1//COMMIT_MSG
Commit Message:

Line 14: cgi
we should finalize on the bz before taking this workaround.  I see this patch as workaround (blivet) of workaround (vdsm.lvm)

Timothy Asir has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42782/1//COMMIT_MSG
Commit Message:

Line 10: whatever given value. So that we have used vdsm.storage.lvm
Line 11: module to create pv. But due to some lvm configuration
Line 12: VDSM also creates pv with 1mb dataalignment value.
Line 13: Seperate bug oppend for vdsm to fix this issue in
Line 14: https://bugzilla.redhat.com/show_bug.cgi?id=1235086
> we should finalize on the bz before taking this workaround.  I see this pat

I will update this commit message properly
Line 15: This patch uses lvm pvcreate command as a workaround till
Line 16: this bug fixed in either vdsm or blivet.
Line 17: 
Line 18: Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 2:

* Update tracker::#1178705::OK
* Check Bug-Url::OK
* Check Public Bug::#1178705::OK, public bug
* Check Product::#1178705::SKIPPED, not (oVirt Red Hat Enterprise Virtualization Manager) product but Red Hat Enterprise Linux 7
* Check Product::WARN, no bug url with correct product found, make sure you have at least one bug-url with a product in oVirt Red Hat Enterprise Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Timothy Asir has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 2: Verified+1

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 4:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225831::ERROR, private bug
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Bala.FA has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 4: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 4:

Unrelated CI error:

DEBUG util.py:378:  http://mirrors.kernel.org/fedora/updates/21/x86_64/o/openssl-libs-1.0.1k-10....: [Errno 14] HTTP Error 404 - Not Found

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225831::ERROR, private bug
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Timothy Asir has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5: Verified+1

Bala.FA has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5: Code-Review+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5: Code-Review+1

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 5: Code-Review+2

raising Nir's score, as I was afraid of accessing pvcreate directly.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

gluster: create pv with custom dataalignment value

Blivet creates pv with 1mb dataalignment forcefully for
whatever given value. This patch uses lvm pvcreate command till
this bug fixed in blivet.

Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225831
Signed-off-by: Timothy Asir Jeyasingh 
Reviewed-on: https://gerrit.ovirt.org/42782
Continuous-Integration: Jenkins CI
Reviewed-by: Bala.FA 
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/gluster/storagedev.py
1 file changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Timothy Asir: Verified
  Bala.FA: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved

[e-mail] has posted comments on this change.

Change subject: gluster: create pv with custom dataalignment value
......................................................................

Patch Set 6:

* update_tracker: OK
* Set MODIFIED::bug 1225831::::#1225831::::IGNORE, not oVirt prod but