9:16 a.m.
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Make resource manager stress test use 75% of allowed nprocs instead of a fixed number
Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M tests/resourceManagerTests.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/3485/1
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
7:54 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:53 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 2: Fails
`make check` fails with multiple redefenitions of the global name `resource`
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:02 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Make resource manager stress test use 75% of allowed nprocs instead of a fixed number
Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M tests/resourceManagerTests.py
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Peter V. Saveliev: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:02 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:58 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:44 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:10 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Make resource manager stress test use 75% of allowed nprocs instead of a
fixed number
......................................................................
Patch Set 3: Fails
(1 inline comment)
everyone should run unit tests before submitting code - in particular if you submit code
for a unit test ;-)
....................................................
File tests/resourceManagerTests.py
Line 30: from testValidation import slowtest, RLIMIT_NPROC
this should be imported from "resource"!
--
To view, visit http://gerrit.ovirt.org/3485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7679303331a2f7a3b6a09b1b59f5e62190d7951
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4444
days inactive
4448
days old
vdsm-patches@lists.fedorahosted.org
7 comments
3 participants
participants (3)
-
Dan Kenigsberg -
peet＠redhat.com -
smizrahi＠redhat.com