Change in vdsm[master]: networkTests: Use bond5 in functional network tests.

Ondřej Svoboda has uploaded a new change for review.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................

networkTests: Use bond5 in functional network tests.

bond0, originally used in the tests, is one of netinfo.REQUIRED_BONDINGS,
which are never deleted. In one approach to resetting bonding
options, this is done by deleting the bond -- bond0 would be unaffected.

Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/28141/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index a572a33..e17f2e4 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -49,7 +49,7 @@
 
 NETWORK_NAME = 'test-network'
 VLAN_ID = '27'
-BONDING_NAME = 'bond0'
+BONDING_NAME = 'bond5'
 IP_ADDRESS = '240.0.0.1'
 IP_NETWORK = '240.0.0.0'
 IP_ADDRESS_IN_NETWORK = '240.0.0.50'


-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................


Abandoned

no longer needed with REQUIRED_BONDINGS quarantined

-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/28141/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 479: 
Line 480:         status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
Line 481:                                                bond=BONDING_NAME,
Line 482:                                                opts={'bridged':
bridged})
Line 483:         self.assertEqual(status, errors.ERR_BAD_BONDING, msg)
please explain in the commit message why this is necessary/relevant.
Line 484: 
Line 485:     @cleanupNet
Line 486:     @permutations([[True], [False]])
Line 487:     @RequireDummyMod


-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8560/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9494/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9348/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................


Patch Set 1:

(1 comment)

ERR_BAD_BONDING is the exception we are getting now.

http://gerrit.ovirt.org/#/c/28141/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 493:                      for index in range(VLAN_COUNT)]
Line 494:         with dummyIf(1) as nics:
Line 495:             firstVlan, firstVlanId = NET_VLANS[0]
Line 496:             status, msg = self.vdsm_net.addNetwork(firstVlan, vlan=firstVlanId,
Line 497:                                                    nics=nics, opts=opts)
As a bond5 does not exist (bond0 did, which was assumed), ERR_BAD_BONDING is raised
instead.
Line 498:             self.assertEquals(status, SUCCESS, msg)
Line 499:             with nonChangingOperstate(nics[0]):
Line 500:                 for netVlan, vlanId in NET_VLANS[1:]:
Line 501:                     status, msg = self.vdsm_net.addNetwork(netVlan,


-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: networkTests: Use bond5 in functional network tests.
......................................................................


Patch Set 1: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8559/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : The patch
does not pass the network functional tests

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9493/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9347/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No