Change in vdsm[master]: Add default MTU=1500 to NIC's ifcfg files.

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Add default MTU=1500 to NIC's ifcfg files.

When we add bridge with custom MTU on top of nic, this MTU will be set properly
on interface. But if we'll remove this bridge (including removing of MTU
keyword from NIC's ifcfg file) and add instead the bridge with default MTU
(without MTU keyword at all in ifcfg file) the actual MTU on the interface
will stay as before.
The only way to change the actual MTU is add MTU keyword explicitly to ifcfg file.

Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=873745
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/9547/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 75f6e43..570f6b1 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -515,7 +515,7 @@
         try:
             hwlines = [line for line in open(cf).readlines()
                        if line.startswith('HWADDR=')]
-            l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n'] + hwlines
+            l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=1500\n'] + hwlines
             open(cf, 'w').writelines(l)
         except IOError:
             pass

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/225/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/191/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/191/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/225/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: oVirt Jenkins CI Server

Hunt Xu has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 514:         self._backup(cf)
Line 515:         try:
Line 516:             hwlines = [line for line in open(cf).readlines()
Line 517:                        if line.startswith('HWADDR=')]
Line 518:             l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=1500\n'] + hwlines
I do not think this change is consistent enough. Let us assume that there is a nic with a Linux-level default mtu of 2000.

When creating a network on top of this nic, we'd be using mtu=2000. After deleting this network, and creating it again, we'd be using mtu=1500 according to your setting here.

We should better have a vdsm-wide default MTU for cases where MTU is not supplied by Engine. It should replace "None" in

- mtu = confParams.get('MTU', None)
 + mtu = confParams.get('MTU', str(DEFAULT_MTU))
Line 519:             open(cf, 'w').writelines(l)
Line 520:         except IOError:
Line 521:             pass
Line 522:

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 514:         self._backup(cf)
Line 515:         try:
Line 516:             hwlines = [line for line in open(cf).readlines()
Line 517:                        if line.startswith('HWADDR=')]
Line 518:             l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=1500\n'] + hwlines
oh, after re-adding the network, the MTU=2000 would be removed, so my scenario does not lead to a problem.

I still think that having a clear vdsm-wide default is a bit nicer, but is not required to solve any bug (actually, and ovirt-wide default is even better).
Line 519:             open(cf, 'w').writelines(l)
Line 520:         except IOError:
Line 521:             pass
Line 522:

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Patch Set 1: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................

Add default MTU=1500 to NIC's ifcfg files.

When we add bridge with custom MTU on top of nic, this MTU will be set properly
on interface. But if we'll remove this bridge (including removing of MTU
keyword from NIC's ifcfg file) and add instead the bridge with default MTU
(without MTU keyword at all in ifcfg file) the actual MTU on the interface
will stay as before.
The only way to change the actual MTU is add MTU keyword explicitly to ifcfg file.

Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=873745
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Hunt Xu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Meni Yakove