From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add _command placeholder
......................................................................
v2v: add _command placeholder
The V2VCommand base class should have placeholder also for the
_command() method, which is supposed to be overridden by subclasses,
much like execute().
This also makes pylint a bit happier.
Change-Id: Ib23332445cabc97d8e2026b6973dad7e77bba109
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/v2v.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Dan Kenigsberg: Passed CI tests
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/75855
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23332445cabc97d8e2026b6973dad7e77bba109
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>