Change in vdsm[master]: Fix metadata file permissions for fileSD

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Fix metadata file permissions for fileSD
......................................................................

Fix metadata file permissions for fileSD

Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
---
M vdsm/storage/fileSD.py
M vdsm/storage/outOfProcess.py
2 files changed, 12 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/1252/1
--
To view, visit http://gerrit.ovirt.org/1252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix metadata file permissions for fileSD
......................................................................


Fix metadata file permissions for fileSD

In this patch:
* remove createmetafile (we already have other functions to create an
  empty file)
* create empty metadata files (createmetafile was using sizeStr2Int
  which is wrong)
* set the metadata files permission to 0660

Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
---
M vdsm/storage/fileSD.py
M vdsm/storage/outOfProcess.py
2 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix metadata file permissions for fileSD
......................................................................


Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix metadata file permissions for fileSD
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/fileSD.py
Line 120:                                 os.path.join(metadataDir, metaFile), 0, 0660)
that's more than a change of permissions, but also a change in the created file.

I find the commit message misleading

(yeah, we spoke about it on irc, but let's not forget)

--
To view, visit http://gerrit.ovirt.org/1252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;