Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

Francesco Romani has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
......................................................................

Patch Set 6: Code-Review+1

(2 comments)

we need to sort out one implementation detail and we are good to go.

https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 145:         self._elem.appendChild(child)
Line 146:         return child
Line 147: 
Line 148:     def hasChildNodes(self):
Line 149:         return self._elem.hasChildNodes()
I don't like this - you are adding one utility used only in one place,  which has good workarounds.
Do you see other usage in the near future for this?
Line 150: 
Line 151: 
Line 152: class Domain(object):
Line 153:

PS6, Line 524: hasChildNodes
if this is used just there, with no plan for further enhancments, I'd like to use an equivalent approach, like a boolean or something like this.

Rationale: we want to switch to etree in the not-so-distant future, so we want to add utilities to our xml processing only if stricly needed. This doesn't seem the case.