4:09 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
vdsm-logrotate: change rotate to 10
Logrotate compress VDSM logs (/var/log/vdsm/*) when they achieve >15M.
However, we rotates the logs only when it reaches 100 count.
This patch purpose the rotation to 10 counts because very old logs
cannot help to get out of trouble anyway. Also, reduce the number of
files/space in the partition.
Rotating 10 files compressed seems reasonable/safe.
Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928217
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm/vdsm-logrotate.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/13500/1
diff --git a/vdsm/vdsm-logrotate.conf.in b/vdsm/vdsm-logrotate.conf.in
index ce71015..4b270fb 100644
--- a/vdsm/vdsm-logrotate.conf.in
+++ b/vdsm/vdsm-logrotate.conf.in
@@ -1,5 +1,5 @@
/var/log/vdsm/*.log {
- rotate 100
+ rotate 10
missingok
size 15M
compress
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
4:11 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1767/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1818/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:09 a.m.
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:34 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
Hi Dan,
that's a next patch in my todo list.
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:46 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I kinda like the ability to see older logs, by default. How about saving space by stopping
the collection of /var/log/vdsm/libvirt.log ?
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:12 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
It is %config, user can alter it to whatever needed.
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:36 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
Hi Yaniv, make sense, I will share there. I have used 10 based on my experiences on
support days.
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:05 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
It sounds reasonable alright, but between 100 to 10 files of log that each 15mb we loose
huge amount of log. I would open it as part of the bugzilla's comments to allow QE
guys to comment and confirm that we don't use such old log files... why 10? why not
50?..
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:36 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:09 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1818/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:09 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1767/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:10 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-logrotate: change rotate to 10
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28d84c455d0a2719855a33fc6861b4a74317fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4036
days inactive
4037
days old
vdsm-patches@lists.fedorahosted.org
11 comments
6 participants
participants (6)
-
Alon Bar-Lev -
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO -
ybronhei＠redhat.com -
zhshzhou＠linux.vnet.ibm.com