Nir Soffer has uploaded a new change for review.
Change subject: sp: Remove double dict key ......................................................................
sp: Remove double dict key
Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second "pool_status" key in the same dictionary. Turns out that this is well defined, and the second key overrides the first one. Remove the old unused key.
For more info see: https://docs.python.org/2/reference/expressions.html#dictionary-displays
Change-Id: I05f6aeda1858e85b8660d972593e82bcb7e3bff3 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/sp.py 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/65051/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index dabe892..dbc89c9 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1367,7 +1367,6 @@ 'master_ver': self._backend.getMasterVersion(), 'lver': LVER_INVALID, 'spm_id': SPM_ID_FREE, - 'pool_status': 'uninitialized', 'version': str(msdInfo['version']), 'isoprefix': '', 'pool_status': 'connected',
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 1:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 1: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 2:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 3:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 4:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 5:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Allon Mureinik has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
+1 on the code, see inline comment wrt the commit message.
https://gerrit.ovirt.org/#/c/65051/5//COMMIT_MSG Commit Message:
PS5, Line 11: Remove the old : unused key. s/Remove/This patch removes/
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 6:
* #2::Update tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65051/5//COMMIT_MSG Commit Message:
Line 8: Line 9: Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second Line 10: "pool_status" key in the same dictionary. Turns out that this is well Line 11: defined, and the second key overrides the first one. Remove the old Line 12: unused key.
s/Remove/This patch removes/
Fixed in current version. Line 13: Line 14: For more info see: Line 15: https://docs.python.org/2/reference/expressions.html#dictionary-displays Line 16:
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 7: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Freddy Rolland has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 8: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 9: Code-Review+2
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove double dict key ......................................................................
sp: Remove double dict key
Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second "pool_status" key in the same dictionary. Turns out that this is well defined, and the second key overrides the first one. This patch removes the old unused key.
For more info see: https://docs.python.org/2/reference/expressions.html#dictionary-displays
Change-Id: I05f6aeda1858e85b8660d972593e82bcb7e3bff3 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65051 Reviewed-by: Freddy Rolland frolland@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke alitke@redhat.com --- M vdsm/storage/sp.py 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org