Federico Simoncelli has uploaded a new change for review.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
sp: refreshDomainLinks before convertDomain
Domain conversion requires the links to be present.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948346 Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/13633/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 82052df..fe54dd9 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1109,6 +1109,8 @@ if domainStatuses[sdUUID] == sd.DOM_ACTIVE_STATUS: return True
+ # Domain conversion requires the links to be present + self._refreshDomainLinks(dom) if dom.getDomainClass() == sd.DATA_DOMAIN: self._convertDomain(dom)
@@ -1116,7 +1118,6 @@ # set domains also do rebuild domainStatuses[sdUUID] = sd.DOM_ACTIVE_STATUS self.setMetaParam(PMDK_DOMAINS, domainStatuses) - self._refreshDomainLinks(dom) self.updateMonitoringThreads() return True
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1825/ (1/2)
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1876/ (2/2)
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1825/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1876/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
Patch Set 1: Verified
Verified: activating (and upgrading) a domain with missing links is now possible.
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: refreshDomainLinks before convertDomain ......................................................................
sp: refreshDomainLinks before convertDomain
Domain conversion requires the links to be present.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948346 Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/13633 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If5d2481235bb54119be864a4a6bbb220718ade55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org