Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Initialize the block sizes metadata
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 242: self.metavol = lvm.lvPath(self.sdUUID, sd.METADATA)
Line 243:
Line 244: try:
Line 245: self.logBlkSize = self.getMetaParam(DMDK_LOGBLKSIZE)
Line 246: self.phyBlkSize = self.getMetaParam(DMDK_PHYBLKSIZE)
Both values must be set in the metadata asap since we need them to understand if in the
future they have changed (eg: a cloned lun but somehow exposing a different block size).
Line 247: except KeyError:
Line 248: # Initialize the block sizes metadata if not defined
Line 249: self.logBlkSize, self.phyBlkSize = lvm.getVGBlockSizes(sdUUID)
Line 250: self.setMetaParam(DMDK_LOGBLKSIZE, self.logBlkSize)
--
To view, visit
http://gerrit.usersys.redhat.com/992
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0baa4addabc31389ea1656099f7c9d2d70cd85a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>