From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Create libvirt network only when needed
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/74390/2/lib/vdsm/network/libvirt.py
File lib/vdsm/network/libvirt.py:
PS2, Line 202: NetworksUsersCache
This was one of my initial solutions, but I felt it is not fully safe
to ju
Since it's all done under _libvirt_net_lock, we don't even need a
Counter, a mere integer would do.
Much like Eddy, I cannot point my finger on why I prefer keeping a reference over a
reference count. I think that keeping a reference can be justified if we add a
logging.error("attempting to add an existing libvirt network user")
If we have a bug in the code, we can protect against it, but we should also track it so it
can be fixed.
--
To view, visit
https://gerrit.ovirt.org/74390
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie55b08e9bdffcd8ea663b647c6d6dcf3363b9847
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes