Change in vdsm[master]: virtTests: add way to query full stats via jsonrpc

[Martin Polednik]

Martin Polednik has uploaded a new change for review.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

virtTests: add way to query full stats via jsonrpc

Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af
Signed-off-by: Martin Polednik 
---
M lib/vdsm/jsonrpcvdscli.py
M tests/functional/utils.py
2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/45309/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 6e65e0d..eda01c4 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -43,6 +43,7 @@
     'getVdsStats': 'Host.getStats',
     'getVmStats': 'VM.getStats',
     'list': 'Host.getVMList',
+    'fullList': 'Host.getVMFullList',
     'migrationCreate': 'VM.migrationCreate',
     'ping': 'Host.ping',
     'setBalloonTarget': 'VM.setBalloonTarget',
diff --git a/tests/functional/utils.py b/tests/functional/utils.py
index 26562aa..1414386 100644
--- a/tests/functional/utils.py
+++ b/tests/functional/utils.py
@@ -221,7 +221,7 @@
             return _parse_result(result)

def getVmList(self, vmId):
-        result = self.vdscli.list('true', [vmId])
+        result = self.vdscli.getVMFullList()
         code, msg, vm_list = _parse_result(result, True)
         return code, msg, vm_list[0]

[e-mail] has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Yeela Kaplan has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45309/1/tests/functional/utils.py
File tests/functional/utils.py:

Line 220:         else:
Line 221:             return _parse_result(result)
Line 222: 
Line 223:     def getVmList(self, vmId):
Line 224:         result = self.vdscli.getVMFullList()
I think you should keep the test as is by giving parameter:
self.vdscli.getVMFullList([vmId])
Line 225:         code, msg, vm_list = _parse_result(result, True)
Line 226:         return code, msg, vm_list[0]
Line 227: 
Line 228:     def getVdsCapabilities(self):

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2: Code-Review+1

Yeela Kaplan has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2: Code-Review-1

I think you should keep the test as is by giving parameter: self.vdscli.getVMFullList([vmId])

But other than that patch is good.

[Martin Polednik]

Martin Polednik has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2:

the argument is ignored because of code in Bridge.py, we need better solution of kwargs passing

Yeela Kaplan has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2:

Piotr has presented a patch that will help with this: 
https://gerrit.ovirt.org/#/c/45429/

Let's get this one ready in the meantime...

Yeela Kaplan has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2:

Martin, I have to take this 2-liner into the functional tests patch.
Getting either one of them in without the other will break the tests...
Is that OK by you?

[Martin Polednik]

Martin Polednik has abandoned this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Abandoned

[e-mail] has posted comments on this change.

Change subject: virtTests: add way to query full stats via jsonrpc
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found