Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
vdsm-reg: avoid issuing errors to console
Using logging.error() during the ovirt-node dialog results in writing messages to console. This is undesired in dialog mode.
Change the error to debug to avoid.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947905 Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/13561/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in index f2bef9d..3b056ca 100644 --- a/vdsm_reg/deployUtil.py.in +++ b/vdsm_reg/deployUtil.py.in @@ -1720,7 +1720,7 @@
return True except: - logging.error( + logging.debug( "Failed acquiring web certificates", exc_info=True ) @@ -1736,10 +1736,10 @@ fp = filter(lambda l: 'Fingerprint' in l, out.split())[0].split('=')[1] except Exception: - logging.error("Failed generating finger print for %s", path, + logging.debug("Failed generating finger print for %s", path, exc_info=True) else: - logging.error("Command %s failed with return value %d", + logging.debug("Command %s failed with return value %d", ' '.join(cmd), rc)
return fp
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1844/ (1/2)
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1793/ (2/2)
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1793/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1844/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-reg: avoid issuing errors to console ......................................................................
vdsm-reg: avoid issuing errors to console
Using logging.error() during the ovirt-node dialog results in writing messages to console. This is undesired in dialog mode.
Change the error to debug to avoid.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947905 Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/13561 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ib25f516b74dc03cca4fe696467121c8e8db06b76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org