Change in vdsm[master]: log: Use INFO log level as default

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: log: Use INFO log level as default
......................................................................

log: Use INFO log level as default

The current logs are much too verbose which cause trouble for users, and
make us look unprofessional. Mature project should not use debug log by
default.

To debug issues that are not clear enough using INFO logs, the relevant
logger level can be modified on a user machine as needed.

Change-Id: I767dcd9bad7b9fbeebb438e9ef13cb0ec3f042ee
Signed-off-by: Nir Soffer 
---
M vdsm/logger.conf.in
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/32504/1

diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in
index 64b154f..8e963dd 100644
--- a/vdsm/logger.conf.in
+++ b/vdsm/logger.conf.in
@@ -8,18 +8,18 @@
 keys=long,simple,none,sysform

[logger_root]
-level=DEBUG
+level=INFO
 handlers=syslog,logfile
 propagate=0

[logger_vds]
-level=DEBUG
+level=INFO
 handlers=syslog,logfile
 qualname=vds
 propagate=0

[logger_Storage]
-level=DEBUG
+level=INFO
 handlers=logfile
 qualname=Storage
 propagate=0
@@ -31,7 +31,7 @@
 propagate=1

[logger_connectivity]
-level=DEBUG
+level=INFO
 handlers=connlogfile
 qualname=connectivity
 propagate=0

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11332/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12276/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12121/ : SUCCESS

Francesco Romani has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32504/1//COMMIT_MSG
Commit Message:

Line 7: log: Use INFO log level as default
Line 8: 
Line 9: The current logs are much too verbose which cause trouble for users, and
Line 10: make us look unprofessional. Mature project should not use debug log by
Line 11: default.
I fully agree with this statement and I want to improve things in my area.

Unfortunately, logging in virt/* isn't in a very good shape (and I have my fair share of guilt of jus dumping things in debug()), so some time to catch up and clean things will be needed.
Line 12: 
Line 13: To debug issues that are not clear enough using INFO logs, the relevant
Line 14: logger level can be modified on a user machine as needed.
Line 15:

[Martin Sivak]

Martin Sivák has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

What about logging both INFO and DEBUG but with different rotation period?

Something like DEBUG keeps only last 6 files and rotates every hour and INFO keeps couple of days and rotates once per day?

That would allow diagnosing weird issues that are hard to reproduce and reduce the logging noise at the same time.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

Martin, do you like to send a patch implementing what you suggest?

Francesco Romani has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

I'm fine with this patch but before to have the default switched I need to audit my own logs (and hopefully shed some of them).

Francesco Romani has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

I'll be fine with this patch once this topic branch is in:
http://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:vir...

after that, I'll continue the virt log sanitization, adding a separate logger if/where makes sense

Yaniv Bronhaim has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1: Code-Review-1

any bug about that? this issue needs to be discussed in way bigger form. please open or add to https://bugzilla.redhat.com/show_bug.cgi?id=1078745

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

I will change this patch to modify only storage logs.

Michal Skrivanek has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

please get something into 3.6 already. The verbosity is terrible, not only in storage

Yaniv Bronhaim has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1:

following last vdsm call - lets move on with that if we all agree to set INFO as default.

Francesco Romani has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1: Code-Review+1

I can't think of a better time to do this switch.

Michal Skrivanek has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1: Code-Review+1

Milan Zamazal has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 1: Code-Review-1

I support this change but it needs rebase and update -- there have been added new level=DEBUG items to logger.conf.in since this patch was created.

gerrit-hooks has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2:

Rebase, update new logger added since the original patch.

Milan Zamazal has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2: Code-Review+1

Francesco Romani has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2: Code-Review+1

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2: Code-Review+2

Milan Zamazal has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 2: Verified+1

Verified that DEBUG messages are no longer present in the log and the higher level messages are still there.

[Nir Soffer]

Nir Soffer has submitted this change and it was merged.

Change subject: log: Use INFO log level as default
......................................................................

log: Use INFO log level as default

The current logs are much too verbose which cause trouble for users, and
make us look unprofessional. Mature project should not use debug log by
default.

To debug issues that are not clear enough using INFO logs, the relevant
logger level can be modified on a user machine as needed.

Change-Id: I767dcd9bad7b9fbeebb438e9ef13cb0ec3f042ee
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/32504
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Francesco Romani 
Reviewed-by: Piotr Kliczewski 
Tested-by: Milan Zamazal 
---
M vdsm/logger.conf.in
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Milan Zamazal: Verified; Looks good to me, but someone else must approve

gerrit-hooks has posted comments on this change.

Change subject: log: Use INFO log level as default
......................................................................

Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.