Change in vdsm[master]: Restore optional drive cap.

Eduardo has uploaded a new change for review.

Change subject: Restore optional drive cap.
......................................................................

Restore optional drive cap.

Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
---
M vdsm/clientIF.py
1 file changed, 8 insertions(+), 14 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/1935/1
--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 1: (2 inline comments)

....................................................
File vdsm/clientIF.py
Line 179:                 drive['blockDev'] = True
Why did you switch back to setting this instead of using utils.isBlockDevice()?

Line 199:         self.log.info("prepared volume path: %s" % volPath)
No need to use "%" here.

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

Saggi Mizrahi has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Everything Federico said. Why did you remove all the space lines?

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 1: (2 inline comments)

The blank lines where removed by accident, can return for free.

....................................................
File vdsm/clientIF.py
Line 179:                 drive['blockDev'] = True
isBlockDevices raises when the path is inexstent, exactly what optional CDRom or floppy is.
There is no need to determine here since is a parameter known in advance.

Line 199:         self.log.info("prepared volume path: %s" % volPath)
In the original

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 1: (2 inline comments)

If you want to set blockDev it's fine by me (check with Igor, he wanted to use isBlockDevice) but don't revert stuff that was fixed (blank lines, the "%" in the log message and the mysterious "elif not drive").

....................................................
File vdsm/clientIF.py
Line 191:         elif not drive:
Do you know exactly what is doing this? Looks like it's going to set volPath = None when drive == None. Is that correct?

Line 199:         self.log.info("prepared volume path: %s" % volPath)
Does it mean that it's something you reverted by accident and that you are going to fix it?

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 4: Verified

Passed  *OptionalCDRomTests

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Restore optional drive cap.
......................................................................

Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Restore optional drive cap.
......................................................................

Restore optional drive cap.

Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
---
M vdsm/clientIF.py
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Eduardo: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi