Change in vdsm[master]: move monitored_paths to configure.ac

[Xu He Jie]

Xu He Jie has uploaded a new change for review.

Change subject: move monitored_paths to configure.ac
......................................................................

move monitored_paths to configure.ac

move monitored_paths to configure.ac, then we can make it configurable

Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Signed-off-by: Xu He Jie 
---
M build-aux/Makefile.subs
M configure.ac
M vdsm/constants.py.in
M vdsm/utils.py
4 files changed, 10 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/5153/1
--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: move monitored_paths to configure.ac
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Xu He Jie

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: move monitored_paths to configure.ac
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Xu He Jie

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: move monitored_paths to configure.ac
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File configure.ac
Line 85: AC_SUBST([vdsmmonitoredpaths],
Rather than a build time configuration, I'd make it a run time option, eg: vdsm.conf

--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Xu He Jie

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: move monitored_paths to configure.ac
......................................................................

Patch Set 4: (1 inline comment)

....................................................
File configure.ac
Line 85: AC_SUBST([vdsmmonitoredpaths],
ok, so vdsm-tool verb 'configure-core-dump' need a tools to modify vdsm.conf at runtime when coredump was disabled or enabled. Actually， I submitted a patch 'actually' before, but for keep this core-dump simple, I abandoned it by myself. If this  is worth maintianing a new-class to write config file. I will resubmit that patch. Thanks for the review!

--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Xu He Jie

[Xu He Jie]

Xu He Jie has abandoned this change.

Change subject: move monitored_paths to configure.ac
......................................................................

Patch Set 4: Abandoned

--
To view, visit http://gerrit.ovirt.org/5153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5d2c468c56f0c97eadacd1905c7e7def5a207963
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server