6:52 a.m.
New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/873
commit a9eeef14fb9f786336d3d04bdf6f367af0e6147e
Author: Eduardo Warszawski <ewarszaw(a)redhat.com>
Date: Wed Aug 24 21:38:39 2011 +0300
Related to BZ#732416 - Unify criteria for active LV in lvm cache.
Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 921cf3b..ca90329 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -981,11 +981,10 @@ def createLV(vgName, lvName, size, activate=True, contiguous=False,
initialTag=N
def removeLV(vgName, lvName):
#Assert that the LV is inactive before remove.
- lv = _lvminfo._lvs.get((vgName, lvName), None)
- if lv and not isinstance(lv, Stub) and lv.active:
+ if os.path.exists(lvPath(vgName, lvName)):
#Fix me
#Should not remove active LVs
- #raise se.CannotRemoveLogicalVolume(vg, lv)
+ #raise se.CannotRemoveLogicalVolume(vgName, lvName)
log.warning("Removing active volume %s/%s" % (vgName, lvName))
#LV exists or not in cache, attempting to remove it.
4:26 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Related to BZ#732416 - Unify criteria for active LV in lvm cache.
Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
---
M vdsm/storage/lvm.py
1 file changed, 12 insertions(+), 5 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
Saggi Mizrahi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:26 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:50 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:40 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 985: #Fix me
it should be "#FIXME : Should not remove active LVs"
this will not be caught by common greppers
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:25 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/lvm.py
Line 1120: This function sould be not used out of this module.
"should not be"
Line 1122: return os.path.exists(lvPath(vgName, lvName))
double space
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:13 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:30 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 984: if os.path.exists(lvPath(vgName, lvName)):
It doesn't matter. the current line doesn't convey what you want to do.
isLvActive() does. I'll also give us grater flexibility to change this when we get a
better solution
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:57 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Eduardo Warszawski has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 984: if os.path.exists(lvPath(vgName, lvName)):
This verification should be removed as stated in the comment below and is here only for
debuging purposes.
Path activation status is not an issue outside of the lvm module.
Therefore is better that such function does not exists, then can't be used outside.
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:24 a.m.
New subject: Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...
Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 984: if os.path.exists(lvPath(vgName, lvName)):
Move into a function called isLvActive()
--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4609
days inactive
4620
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
ewarszaw＠redhat.com -
Igor Lvovsky -
smizrahi＠redhat.com