Change in vdsm[master]: '0' is a valid master version

Shu Ming has uploaded a new change for review.

Change subject: '0' is a valid master version
......................................................................

'0' is a valid master version

When connecting the storage pool first time with
master domain version '0', exception happens not
finding the temporary pool file for pool parameters.

Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0
Signed-off-by: Shu Ming 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/7948/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 1e9311b..f7f8b49 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -849,7 +849,7 @@
                 return

pool = sp.StoragePool(spUUID, self.taskMng)
-            if not hostID or not scsiKey or not msdUUID or not masterVersion:
+            if not hostID or not scsiKey or not msdUUID or (masterVersion == None):
                 hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams()
             res = pool.connect(hostID, scsiKey, msdUUID, masterVersion)
             if res:

--
To view, visit http://gerrit.ovirt.org/7948
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming

Adam Litke has posted comments on this change.

Change subject: '0' is a valid master version
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 848:                 pool.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion)
Line 849:                 return
Line 850: 
Line 851:             pool = sp.StoragePool(spUUID, self.taskMng)
Line 852:             if not hostID or not scsiKey or not msdUUID or (masterVersion == None):
masterVersion is None
Line 853:                 hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams()
Line 854:             res = pool.connect(hostID, scsiKey, msdUUID, masterVersion)
Line 855:             if res:
Line 856:                 self.pools[spUUID] = pool

--
To view, visit http://gerrit.ovirt.org/7948
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

Shu Ming has posted comments on this change.

Change subject: '0' is a valid master version
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 848:                 pool.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion)
Line 849:                 return
Line 850: 
Line 851:             pool = sp.StoragePool(spUUID, self.taskMng)
Line 852:             if not hostID or not scsiKey or not msdUUID or (masterVersion == None):
Adam, masterversion = 0 here will make "not masterVersion" to be true.  And the pool.getPoolParams() will be called, tough the temporary pool file is not initialized yet.
Line 853:                 hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams()
Line 854:             res = pool.connect(hostID, scsiKey, msdUUID, masterVersion)
Line 855:             if res:
Line 856:                 self.pools[spUUID] = pool

--
To view, visit http://gerrit.ovirt.org/7948
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming

Saggi Mizrahi has posted comments on this change.

Change subject: '0' is a valid master version
......................................................................

Patch Set 1:

Should this be abandoned?

Itamar Heim has posted comments on this change.

Change subject: '0' is a valid master version
......................................................................

Patch Set 1:

ping?

Shu Ming has abandoned this change.

Change subject: '0' is a valid master version
......................................................................

Abandoned

It seems most of the people don't agree on it.