Nir Soffer has uploaded a new change for review.
Change subject: sp: Remove vol_extend_policy option ......................................................................
sp: Remove vol_extend_policy option
We had a vol_extend_policy option disabling the mailbox. This option is not useful for anything but causing vms using thin block disks to pause without a way to recover.
This option was added in commit 73adfc489e6e (Add spmProtect, release lock and toggle lock functionality. Add toggle lvextend functionality) in 2009. I did not find why this option was added.
Change-Id: Ib067c09a985a633a452c476e21d8c2c073e6ca50 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M lib/vdsm/config.py.in M vdsm/storage/sp.py 2 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/65053/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in index 94640b2..55ce6f3 100644 --- a/lib/vdsm/config.py.in +++ b/lib/vdsm/config.py.in @@ -329,8 +329,6 @@ 'NFS mount options, comma-separated list (NB: no white space ' 'allowed!)'),
- ('vol_extend_policy', 'ON', None), - ('lock_util_path', '@LIBEXECDIR@', None),
('lock_cmd', 'spmprotect.sh', None), diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 8f98205..febd444 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -68,7 +68,6 @@
log = logging.getLogger('storage.StoragePool') storage_repository = config.get('irs', 'repository') - lvExtendPolicy = config.get('irs', 'vol_extend_policy')
def __init__(self, spUUID, domainMonitor, taskManager): self._secured = threading.Event() @@ -315,9 +314,7 @@ # commands are allowed to run to prevent a race between the # mailbox and the "self._setSecure() call"
- # FIXME : Use a system wide grouping mechanism - if (self.lvExtendPolicy == "ON" and - self.masterDomain.supportsMailbox): + if self.masterDomain.supportsMailbox: self.masterDomain.prepareMailbox() self.spmMailer = storage_mailbox.SPM_MailMonitor(self, maxHostID) @@ -450,8 +447,7 @@ if self.hsmMailer: return
- if (self.lvExtendPolicy == "ON" and - self.masterDomain.supportsMailbox): + if self.masterDomain.supportsMailbox: self.hsmMailer = storage_mailbox.HSM_Mailbox(self.id, self.spUUID) self.log.debug("HSM mailbox ready for pool %s on master " "domain %s", self.spUUID, self.masterDomain.sdUUID)
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 8: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Freddy Rolland has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 9: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 10: Code-Review+2
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 11: Continuous-Integration+1
Jenkins el7 build is broken now, wont even start.
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove vol_extend_policy option ......................................................................
sp: Remove vol_extend_policy option
We had a vol_extend_policy option disabling the mailbox. This option is not useful for anything but causing vms using thin block disks to pause without a way to recover.
This option was added in commit 73adfc489e6e (Add spmProtect, release lock and toggle lock functionality. Add toggle lvextend functionality) in 2009. I did not find why this option was added.
Change-Id: Ib067c09a985a633a452c476e21d8c2c073e6ca50 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65053 Reviewed-by: Freddy Rolland frolland@redhat.com Reviewed-by: Adam Litke alitke@redhat.com --- M lib/vdsm/config.py.in M vdsm/storage/sp.py 2 files changed, 2 insertions(+), 8 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve
Objections: Jenkins CI: Failed CI tests
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option ......................................................................
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org