Change in vdsm[master]: net: fix test_setupNetworks_on_external_bond

Petr Horáček has uploaded a new change for review.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................

net: fix test_setupNetworks_on_external_bond

In this test we manualy write slave names to bond's BONDING_SLAVES file.
Unfortunately, when we try to enslave a nic in UNKNOWN state (left by
a previous test), action explodes with
'IOError: [Errno 1] Operation not permitted'.

Now we set nics explicitly down before enslaving.

Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/45715/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 1873222..c2778bc 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2625,6 +2625,7 @@
             try:
                 with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
                     for nic in nics:
+                        linkSet(nic, ['down'])
                         f.write('+%s\n' % nic)
                 status, msg = self.setupNetworks(
                     {NETWORK_NAME:


-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Petr Horáček has posted comments on this change.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


Patch Set 1: Verified+1

Fixed the test, passed functional network test without a regression.

-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Ondřej Svoboda has posted comments on this change.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


Patch Set 1: Code-Review+1 Verified+1

The test passes on Fedora 22 for me :-)

-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


Patch Set 1: Code-Review+2

thanks! I did wonder.

-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


net: fix test_setupNetworks_on_external_bond

In this test we manualy write slave names to bond's BONDING_SLAVES file.
Unfortunately, when we try to enslave a nic in UNKNOWN state (left by
a previous test), action explodes with
'IOError: [Errno 1] Operation not permitted'.

Now we set nics explicitly down before enslaving.

Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/45715
Continuous-Integration: Jenkins CI
Reviewed-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Tested-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ondřej Svoboda: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: net: fix test_setupNetworks_on_external_bond
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/45715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No