Nir Soffer has uploaded a new change for review.
Change subject: hsm: Pep8ize function name ......................................................................
hsm: Pep8ize function name
Remove unneeded _private prefix for inner function and use lowercase name.
Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/39306/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index a4bb858..8f75a39 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -2070,7 +2070,7 @@ boolean :rtype: dict """ - def _isVisible(guid): + def is_visible(guid): path = os.path.join('/dev/mapper', guid) try: st = os.stat(path) @@ -2081,10 +2081,10 @@ else: return (st.st_mode & stat.S_IRUSR) != 0
- visibility = [_isVisible(guid) for guid in guids] + visibility = [is_visible(guid) for guid in guids] if not all(visibility): multipath.rescan() - visibility = [_isVisible(guid) for guid in guids] + visibility = [is_visible(guid) for guid in guids] visibility = dict(zip(guids, visibility))
# After multipath.rescan, existing devices may disapper, and new
automation@ovirt.org has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17272/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17446/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17272/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17446/ : SUCCESS
Ala Hino has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1: Code-Review+1
Freddy Rolland has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 1: Code-Review+1
Jenkins CI RO has abandoned this change.
Change subject: hsm: Pep8ize function name ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: hsm: Pep8ize function name ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
Nir Soffer has restored this change.
Change subject: hsm: Pep8ize function name ......................................................................
Restored
vdsm-patches@lists.fedorahosted.org