Change in vdsm[master]: sp: Improve logging when pool is destroyed

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: sp: Improve logging when pool is destroyed
......................................................................

sp: Improve logging when pool is destroyed

When pool is destroyed, it tries to stop monitoring domains. I suspect
that this is the root cause of bug 1032925. This patch adds proper
logging to this thread to prove my theory.

The real fix seems to be deleting __del__ as we already stop monitoring
domains when pool is disconnected.

Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b
Bug-Url: https://bugzilla.redhat.com/1032925
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt;
---
M vdsm/storage/sp.py
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/21932/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 31e0bcd..6253bb7 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -142,7 +142,13 @@
 
     def __del__(self):
         if len(self.domainMonitor.poolMonitoredDomains) > 0:
-            threading.Thread(target=self.stopMonitoringDomains).start()
+            @utils.traceback(on=self.log.name)
+            def run():
+                self.log.info("Stop monitoring domains for %s", self.spUUID)
+                self.stopMonitoringDomains()
+            thread = threading.Thread(name="StoragePoolCleanupThread",
+                                      target=run)
+            thread.start()
 
     @unsecured
     def forceFreeSpm(self):


-- 
To view, visit http://gerrit.ovirt.org/21932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: sp: Improve logging when pool is destroyed
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5863/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5955/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5067/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: sp: Improve logging when pool is destroyed
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5899/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5103/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5991/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/21932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has abandoned this change.

Change subject: sp: Improve logging when pool is destroyed
......................................................................


Abandoned

Replaced by http://gerrit.ovirt.org/22058

-- 
To view, visit http://gerrit.ovirt.org/21932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server