Change in vdsm[master]: BZ#802759 - Make old FD shutdown a bit more robust

Saggi Mizrahi has uploaded a new change for review.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

BZ#802759 - Make old FD shutdown a bit more robust

Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
---
M vdsm/storage/processPool.py
1 file changed, 20 insertions(+), 6 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/2844/1
--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

I'd appreciate if you drop a line (here, or in bz) on why close has failed.

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

my request regarding a fatter commit message still applies.

....................................................
File vdsm/storage/processPool.py
Line 280:                         if e in (errno.EINTR, errno.EAGAIN):
actually, this has to be e.errno.

close(2) does not mention EAGAIN.

btw, imho it would be clearer to have

def repeatUntilNoSignal(func, args=[], kwargs={}):
    while True:
        try:
           return func(args, kwargs)
        except OSError as e....

and call repeatUntilNoSignal(os.close).

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

Saggi Mizrahi has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

Patch Set 3: Looks good to me, approved

even though you did not add any flesh to the commit message.

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

Patch Set 6: Verified; Looks good to me, approved

I'm tired of you clearing my acks on this.

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

BZ#802759 - Make old FD shutdown a bit more robust

Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Signed-off-by: Saggi Mizrahi 
---
M vdsm/storage/processPool.py
1 file changed, 28 insertions(+), 6 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi