From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: using io.open in passwd.py
......................................................................
Patch Set 4: Continuous-Integration+1
yaniv, but you can nag the owner of the test about its failure. and if repeated, mark as
@broken_on_ci.
13:04:31 FAIL: test_keep_current (storage_fileutil_test.TestAtomicSymlink)
13:04:31 ----------------------------------------------------------------------
13:04:31 Traceback (most recent call last):
13:04:31 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/storage_fileutil_test.py",
line 139, in test_keep_current
13:04:31 self.assertEqual(current, new)
13:04:31 AssertionError: posix.stat_result(st_mode=41471, st_ino=102260219, st_dev=64515L,
st_nlink=1, st_uid=0, st_gid=0, st_size=25, st_atime=1496062928, st_mtime=1496062928,
st_ctime=1496062929) != posix.stat_result(st_mode=41471, st_ino=102260219, st_dev=64515L,
st_nlink=1, st_uid=0, st_gid=0, st_size=25, st_atime=1496062929, st_mtime=1496062928,
st_ctime=1496062929)
--
To view, visit
https://gerrit.ovirt.org/77433
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85696c7d0b2adf25b9bdb00f77fefdebeb773be9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No