Change in vdsm[ovirt-3.5]: readd back "jsonrpc: StoragePool_removeVM"

Francesco Romani has uploaded a new change for review.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................

readd back "jsonrpc: StoragePool_removeVM"

We need this after 3.5.4 is out

This reverts commit d951f7ac26d77209ec7fc172de90da3fbc7bd5ca.

Change-Id: I99892510753910288592146365f6a438898e7260
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/API.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/45022/1

diff --git a/vdsm/API.py b/vdsm/API.py
index 36fafe2..0c2c46b 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1134,8 +1134,8 @@
     def updateVMs(self, vmList, sdUUID):
         return self._irs.updateVM(self._UUID, vmList, sdUUID)
 
-    def removeVM(self, vmUUID, sdUUID):
-        return self._irs.removeVM(self._UUID, vmUUID, sdUUID)
+    def removeVM(self, vmUUID, storagedomainID=None):
+        return self._irs.removeVM(self._UUID, vmUUID, storagedomainID)
 
 
 class Global(APIBase):


-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* warn_if_not_merged_to_previous_branch: OK

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 1:

to minimize the mess:
- add Bug-Url ?
- add something like Original-Change-Id ?

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* warn_if_not_merged_to_previous_branch: OK

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 3:

* Update tracker::#1237061::OK
* Check Bug-Url::OK
* Check Public Bug::#1237061::OK, public bug
* Check Product::#1237061::OK, Correct product oVirt
* Check TR::#1237061::OK, correct target release 3.5.5
* warn_if_not_merged_to_previous_branch: OK

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 3: Continuous-Integration+1 Verified+1

run make-check manually. Same patch as before, so little risk.

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has submitted this change and it was merged.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


readd back "jsonrpc: StoragePool_removeVM"

We need this after 3.5.4 is out

This reverts commit d951f7ac26d77209ec7fc172de90da3fbc7bd5ca.

Bug-Url: https://bugzilla.redhat.com/1237061
Original-Change-Id: I16acb11982e70ff7f8a05ac816d36b2aa34caea0
Change-Id: I99892510753910288592146365f6a438898e7260
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/45022
Reviewed-by: Allon Mureinik <amureini(a)redhat.com&gt;
---
M vdsm/API.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, but someone else must approve
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: readd back "jsonrpc: StoragePool_removeVM"
......................................................................


Patch Set 4:

* Update tracker::#1237061::OK
* Check TR::#1237061::OK
* Set MODIFIED::bug 1237061::::#1237061::::OK

-- 
To view, visit https://gerrit.ovirt.org/45022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99892510753910288592146365f6a438898e7260
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No