Change in vdsm[master]: Related to BZ#744704 - Do not stop SPM task if in 'racquirin...

Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#744704 - Do not stop SPM task if in 'racquiring'
state
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/task.py
Line 149:         recovered: [recovering],
Line 150:         failed: [recovering, aborting, raborting],
Line 151:     }
Line 152:     _done = [finished, recovered, failed]
Line 153:     _recovering = [racquiring, recovering]
Use tuples or since all this stuff is complicated enough convert the task.state to an
object with all this rules.
Line 154: 
Line 155: 
Line 156:     def __init__(self, state = None):
Line 157:         try:


--
To view, visit http://gerrit.usersys/1042
To unsubscribe, visit http://gerrit.usersys/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;