Change in vdsm[master]: shareVolumeRollback() unique call likes to raise on the unex...

Eduardo has uploaded a new change for review.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

shareVolumeRollback() unique call likes to raise on the unexpected.

Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Signed-off-by: Eduardo 
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
2 files changed, 5 insertions(+), 15 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/11422/1

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 5dec748..355e961 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -335,12 +335,7 @@
     @classmethod
     def shareVolumeRollback(cls, taskObj, volPath):
         cls.log.info("Volume rollback for volPath=%s", volPath)
-
-        try:
-            fileUtils.safeUnlink(volPath)
-
-        except Exception:
-            cls.log.error("Unexpected error", exc_info=True)
+        fileUtils.safeUnlink(volPath)

@deprecated  # valid only for domain version < 3, see volume.setrw
     def _setrw(self, rw):
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index d1c465b..e42fbad 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -260,15 +260,10 @@
     @classmethod
     def shareVolumeRollback(cls, taskObj, volPath):
         cls.log.info("Volume rollback for volPath=%s", volPath)
-
-        try:
-            procPool = oop.getProcessPool(getDomUuidFromVolumePath(volPath))
-            procPool.fileUtils.safeUnlink(volPath)
-            procPool.fileUtils.safeUnlink(cls.__metaVolumePath(volPath))
-            procPool.fileUtils.safeUnlink(cls.__leaseVolumePath(volPath))
-
-        except Exception:
-            cls.log.error("Unexpected error", exc_info=True)
+        procPool = oop.getProcessPool(getDomUuidFromVolumePath(volPath))
+        procPool.fileUtils.safeUnlink(volPath)
+        procPool.fileUtils.safeUnlink(cls.__metaVolumePath(volPath))
+        procPool.fileUtils.safeUnlink(cls.__leaseVolumePath(volPath))

@deprecated  # valid only for domain version < 3, see volume.setrw
     def _setrw(self, rw):

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/932/ (1/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/78/ (2/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/967/ (3/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/932/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/967/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/78/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Thanks for dropping these evil try-except blocks. But wouldn't this cause surprise changes to recovery semantics? The short poetry of the commit message does not assure me that this has been considered.

Please provide more insight on why this would not break task rollback in new forms.

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/980/ (1/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/91/ (2/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/945/ (3/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/945/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/980/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/91/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ayal Baron has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-01-27 11:02:13 +0200
Line 4: Commit:     Eduardo Warszawski 
Line 5: CommitDate: 2013-01-28 10:17:37 +0200
Line 6: 
Line 7: shareVolumeRollback() unique call likes to raise on the unexpected.
I have no idea what this sentence means
Line 8: 
Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path

Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path
Line 12: failed to remove the link (if it exists) because any other reason
Line 13: that an inexistent link; this is clearly unintentional.
I had no idea what you were trying to say here until I read the code (which beats the purpose of the commit message).
The reference to 'unique' still remains in the dark (called only here? why is that relevant in the commit message?).

s/inexistent/nonexistent/

Since the links are being removed with safeUnlink then your example is clearly wrong (as it would not raise an error).
Line 14: 
Line 15: Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Eduardo has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2: (2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-01-27 11:02:13 +0200
Line 4: Commit:     Eduardo Warszawski 
Line 5: CommitDate: 2013-01-28 10:17:37 +0200
Line 6: 
Line 7: shareVolumeRollback() unique call likes to raise on the unexpected.
Danken liked it. Please suggest a better one.
Line 8: 
Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path

Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path
Line 12: failed to remove the link (if it exists) because any other reason
Line 13: that an inexistent link; this is clearly unintentional.
I agree. The code explain it better.
The purpose is to remove safeUnlink. See next patches.
Line 14: 
Line 15: Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yeela Kaplan has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................

Patch Set 2: (2 inline comments)

Hope you like the suggestions.

....................................................
Commit Message
Line 4: Commit:     Eduardo Warszawski 
Line 5: CommitDate: 2013-01-28 10:17:37 +0200
Line 6: 
Line 7: shareVolumeRollback() unique call likes to raise on the unexpected.
Line 8: 
raise on unexpected exceptions in shareVolumeRollback() unique call
Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path
Line 12: failed to remove the link (if it exists) because any other reason

Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path
Line 12: failed to remove the link (if it exists) because any other reason
Line 13: that an inexistent link; this is clearly unintentional.
Line 14: 
Volume.share() (unique) calls shareVolumeRollback() and it should raise an exception if the recovery failed.
Removed try blocks in order to raise exceptions caused by failed volume link removal.
Line 15: Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/219/ (1/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1108/ (2/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1073/ (3/3)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1073/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1108/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/219/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

Daniel Paikov has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3: I would prefer that you didn't submit this

On Jan 27 I've asked for more insight on why this does not cause a regression for Engine.

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

Yeela Kaplan has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 3:

I join Dan's request. Please explain why it does not cause engine regression.

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1843/ (2/2)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1894/ (1/2)

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

shareVolumeRollback() should raise when recovery failed.

Engine does not care whether an exception is thrown during
rollback, as such exception is caught by task.Task._run() when
it is calls the rollback function.
Removed try blocks in order to raise exceptions caused by failed
volume link removal in other than an inexistent link.

Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Signed-off-by: Eduardo 
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
2 files changed, 5 insertions(+), 15 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: shareVolumeRollback() should raise when recovery failed.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: shareVolumeRollback() should raise when recovery failed.
......................................................................

Patch Set 4: Verified; Looks good to me, approved

Copying Paikov's v+1, commit message is clear and convincing.

--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server