Francesco Romani has uploaded a new change for review.
Change subject: tests: fix FakeGuestAgent field ......................................................................
tests: fix FakeGuestAgent field
fix guestIPs, which is supposed to be "A space separated string of assigned IPv4 addresses" and not a list.
Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Signed-off-by: Francesco Romani fromani@redhat.com --- M tests/vmTests.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/28801/1
diff --git a/tests/vmTests.py b/tests/vmTests.py index 483a270..b48aa84 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -836,7 +836,7 @@ 'session': 'Unknown', 'memUsage': 0, 'appsList': [], - 'guestIPs': [], + 'guestIPs': '', 'guestFQDN': '', 'disksUsage': [], 'netIfaces': [],
Francesco Romani has posted comments on this change.
Change subject: tests: fix FakeGuestAgent field ......................................................................
Patch Set 1: Verified+1
Verified by running the existing tests (OK, no regressions) and with http://gerrit.ovirt.org/#/c/28802/1 which implements stricter checks.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix FakeGuestAgent field ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9308/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10093/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10249/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5175/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3333/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: fix FakeGuestAgent field ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix FakeGuestAgent field ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix FakeGuestAgent field ......................................................................
tests: fix FakeGuestAgent field
fix guestIPs, which is supposed to be "A space separated string of assigned IPv4 addresses" and not a list.
Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Signed-off-by: Francesco Romani fromani@redhat.com Reviewed-on: http://gerrit.ovirt.org/28801 Reviewed-by: Vinzenz Feenstra vfeenstr@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/vmTests.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix FakeGuestAgent field ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1476/ : SUCCESS
vdsm-patches@lists.fedorahosted.org