From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Don't configure firewalld unless required in vdsm.conf
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/75099/3/lib/vdsm/tool/configurators/firewall...
File lib/vdsm/tool/configurators/firewalld.py:
Line 66: _add_to_required_services('vdsm.gluster.api', ('glusterfs',
'samba', 'nfs'))
Line 67: _add_to_required_services('cockpit', ('cockpit',))
Line 68:
Line 69:
Line 70: def configure():
I think you should add the condition here too.
otherwise, if some other configurator is answers NO, we'd enable firewalld.
Line 71: if service_status('firewalld') == 1:
Line 72: service_start('firewalld')
Line 73:
Line 74: fw_client = FirewallClient()
Line 79: fw_client.reload()
Line 80:
Line 81:
Line 82: def isconfigured():
Line 83: if config.get('vars', 'firewalld_enable') ==
'false':
Please use utils.tobool() for a more permissive booleanization.
Line 84: return YES
Line 85:
Line 86: if service_status('firewalld') == 1:
Line 87: return NO
--
To view, visit
https://gerrit.ovirt.org/75099
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c46eb2915ef3cb31d4a494070db7ac430672601
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes