Federico Simoncelli has uploaded a new change for review.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Logging shouldn't reach the terminal console
In this patch: * Change the log facility to LOG_DAEMON for SysLogHandler * Remove the handler_console (it's unused now but we don't want anyone to start using it) * Few format cleanups
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 --- M vdsm/logger.conf.in 1 file changed, 6 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/7980/1
diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in index edd4616..f523306 100644 --- a/vdsm/logger.conf.in +++ b/vdsm/logger.conf.in @@ -2,7 +2,7 @@ keys=root,vds,Storage,metadata,SuperVdsm
[handlers] -keys=console,syslog,logfile,metadata +keys=syslog,logfile,metadata
[formatters] keys=long,simple,none,sysform @@ -40,7 +40,7 @@ level=WARNING class=handlers.SysLogHandler formatter=sysform -args=('/dev/log', handlers.SysLogHandler.LOG_USER) +args=('/dev/log', handlers.SysLogHandler.LOG_DAEMON)
[handler_logfile] class=logging.handlers.WatchedFileHandler @@ -55,25 +55,14 @@ level=WARNING formatter=long
-[handler_console] -class: StreamHandler -args: [] -formatter: none - [formatter_simple] -format: %(name)s:%(levelname)s: %(message)s +format=%(name)s:%(levelname)s: %(message)s
[formatter_none] -format: %(message)s +format=%(message)s
[formatter_long] -format: %(threadName)s::%(levelname)s::%(asctime)s::%(module)s::%(lineno)d::%(name)s::(%(funcName)s) %(message)s +format=%(threadName)s::%(levelname)s::%(asctime)s::%(module)s::%(lineno)d::%(name)s::(%(funcName)s) %(message)s
[formatter_sysform] -format= vdsm %(name)s %(levelname)s %(message)s -datefmt= - - - - - +format=vdsm %(name)s %(levelname)s %(message)s
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Mark Wu has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Does logging to syslog work now?
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1:
yes, since http://gerrit.ovirt.org/4247 syslog logging works.
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I still get few sporadic logs to the console. I'm going to investigate it.
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Following federico -1... to avoid showing this patch for review in my queue at this moment.
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Mark Wu has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1:
Federico,
Is it related to the python logging bug reported in https://bugzilla.redhat.com/show_bug.cgi?id=823252#c2 ?
-- To view, visit http://gerrit.ovirt.org/7980 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Itamar Heim has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Patch Set 1:
ping - still relevant?
Itamar Heim has abandoned this change.
Change subject: Logging shouldn't reach the terminal console ......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
vdsm-patches@lists.fedorahosted.org