Change in vdsm[master]: API: drop the bogus _getStats helper method

Francesco Romani has uploaded a new change for review.

Change subject: API: drop the bogus _getStats helper method
......................................................................

API: drop the bogus _getStats helper method

kill this private _getStats() helper: we don't use it anymore.

Change-Id: I5a5497013bffb676565508babd62b6f976d68233
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/API.py
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/64899/1

diff --git a/vdsm/API.py b/vdsm/API.py
index 7467c11..a117a57 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -331,9 +331,6 @@
         """
         Obtain statistics of the specified VM
         """
-        return self._getStats()
-
-    def _getStats(self, runHooks=True):
         # for backward compatibility reasons, we need to
         # do the instance check before to run the hooks.
         vm = self.vm


-- 
To view, visit https://gerrit.ovirt.org/64899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a5497013bffb676565508babd62b6f976d68233
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: API: drop the bogus _getStats helper method
......................................................................


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a5497013bffb676565508babd62b6f976d68233
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: API: drop the bogus _getStats helper method
......................................................................


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a5497013bffb676565508babd62b6f976d68233
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No