Change in vdsm[master]: lvm: remove unused add/remove tags

Yeela Kaplan has uploaded a new change for review.

Change subject: lvm: remove unused add/remove tags
......................................................................

lvm: remove unused add/remove tags

Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M vdsm/storage/lvm.py
M vdsm/storage/storage_exception.py
2 files changed, 0 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/25013/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 24d023d..7e7ad06 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1339,33 +1339,8 @@
             (vgName, ", ".join(delTags), ", ".join(addTags),
err[-1]))
 
 
-def addVGTag(vgName, tag):
-    _lvminfo._invalidatevgs(vgName)
-    cmd = ["vgchange", "--addtag", tag, vgName]
-    rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
-    if rc != 0:
-        raise se.VolumeGroupAddTagError("Failed adding tag %s to VG %s." %
-                                        (tag, vgName))
-
-
-def remVGTag(vgName, tag):
-    _lvminfo._invalidatevgs(vgName)
-    cmd = ["vgchange", "--deltag", tag, vgName]
-    rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
-    if rc != 0:
-        raise se.VolumeGroupRemoveTagError(vgName)
-
-
 def replaceVGTag(vg, oldTag, newTag):
     changeVGTags(vg, [oldTag], [newTag])
-
-
-def addVGTags(vgName, tags):
-    changeVGTags(vgName, addTags=tags)
-
-
-def remVGTags(vgName, tags):
-    changeVGTags(vgName, delTags=tags)
 
 
 def getFirstExt(vg, lv):
diff --git a/vdsm/storage/storage_exception.py b/vdsm/storage/storage_exception.py
index ae68a6f..0317794 100644
--- a/vdsm/storage/storage_exception.py
+++ b/vdsm/storage/storage_exception.py
@@ -1249,16 +1249,6 @@
     message = "Read Volume Group's tag error"
 
 
-class VolumeGroupAddTagError(StorageException):
-    code = 511
-    message = "Add tag to Volume Group error"
-
-
-class VolumeGroupRemoveTagError(StorageException):
-    code = 512
-    message = "Remove tag from Volume Group error"
-
-
 class VolumeGroupScanError(StorageException):
     code = 513
     message = "Volume Group scanning error"


-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lvm: remove unused add/remove tags
......................................................................


lvm: remove unused add/remove tags

Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/25013
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
---
M vdsm/storage/lvm.py
M vdsm/storage/storage_exception.py
2 files changed, 0 insertions(+), 35 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Yeela Kaplan: Verified
  Federico Simoncelli: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6941/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7731/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7843/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6803/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7593/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7703/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 2:

Yeela, please explain how you have verified this patch.

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yeela Kaplan has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 2:

Verified:
Checked that the functions have no uses, 
and also make and ran some manual tests because of locking type for lvm.

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yeela Kaplan has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6511/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7295/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7413/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: remove unused add/remove tags
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6503/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7287/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7405/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No