Change in vdsm[master]: netwiring: [2/3] Add API definitions.

Antoni Segura Puimedon has uploaded a new change for review.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

netwiring: [2/3] Add API definitions.

Second of the Network Wiring feature patches. It adds the cli support
for using the new updateVmDevice feature.

Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Signed-off-by: Antoni S. Puimedon 
---
M vdsm_cli/vdsClient.py
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/9561/1

diff --git a/vdsm_cli/vdsClient.py b/vdsm_cli/vdsClient.py
index 8cb78ed..f188825 100644
--- a/vdsm_cli/vdsClient.py
+++ b/vdsm_cli/vdsClient.py
@@ -205,6 +205,10 @@

return self.ExecAndExit(self.s.create(params))

+    def updateVmDevice(self, args):
+        return self.ExecAndExit(self.s.updateVmDevice(args[0],
+                                                      self._eqSplit(args[1:])))
+
     def hotplugNic(self, args):
         nic = self._parseDriveSpec(args[1])
         nic['type'] = 'interface'
@@ -1737,6 +1741,16 @@
                         'http://libvirt.org/formatdomain.html'
                          '#elementsCPUTuning'
                         )),
+        'updateVmDevice':  (serv.updateVmDevice,
+                         ('<vmId> <devicespec>',
+                          'Update a VM's device',
+                          'devicespec parameters list: r=required, o=optional',
+                          'r   type: interface',
+                          'r   network: network name',
+                          'r   linkState: up|down',
+                          'r   alias: libvirt's vnic alias',
+                          'o   promisc: <blue|red> - Network traffic to mirror'
+                          )),
         'hotplugNic':  (serv.hotplugNic,
                          ('<vmId> <nicspec>',
                           'Hotplug NIC to existing VM',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/233/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/199/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 1: Fails; I would prefer that you didn't submit this

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/199/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/233/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: oVirt Jenkins CI Server

ShaoHe Feng has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'updateVmDevice':  (serv.updateVmDevice,
oVirt Jenkins CI Server has reported UNSTABLE.
violate Pep8 E128 "continuation line under-indented for visual indent"
I suggest update your pep8.
Line 1745:                          ('<vmId> <devicespec>',
Line 1746:                           'Update a VM's device',
Line 1747:                           'devicespec parameters list: r=required, o=optional',
Line 1748:                           'r   type: interface',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'updateVmDevice':  (serv.updateVmDevice,
The problem is that all these methods indentations are wrong according to PEP8. I was trying to keep the same style as the others. Maybe you're right and I should just make this change to be pep8 compliant and later fix the other stuff.
Line 1745:                          ('<vmId> <devicespec>',
Line 1746:                           'Update a VM's device',
Line 1747:                           'devicespec parameters list: r=required, o=optional',
Line 1748:                           'r   type: interface',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

ShaoHe Feng has posted comments on this change.

Change subject: netwiring: [2/3] Add API definitions.
......................................................................

Patch Set 3:

this is jenkins report of  pep8 check for your patch set1
 http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/199/console

"flake8 --diff" will check pep8 of changing code.

in order to avoid jenkins report UNSTABLE again,  you can check pep8 by the follow command before you summit patch
 git diff HEAD~ $(git ls-files| grep '.py$|.py.in$') | flake8 --diff

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add API definitions.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: netwiring: [3/4] Add API definitions.
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',
Line 1749:                             'r   devicetype: interface',
Line 1750:                             'o   network: network name - Non network if not '
s/Non/None
Line 1751:                             ' specified',
Line 1752:                             'o   linkActive: bool - Default: True',
Line 1753:                             'r   alias: libvirt's vnic alias',
Line 1754:                             'o   portMirroring: net[,net] - Networks to mirror'

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add API definitions.

Antoni Segura Puimedon has posted comments on this change.

Change subject: netwiring: [3/4] Add API definitions.
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',
Line 1749:                             'r   devicetype: interface',
Line 1750:                             'o   network: network name - Non network if not '
Done
Line 1751:                             ' specified',
Line 1752:                             'o   linkActive: bool - Default: True',
Line 1753:                             'r   alias: libvirt's vnic alias',
Line 1754:                             'o   portMirroring: net[,net] - Networks to mirror'

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'updateVmDevice': (serv.VmUpdateDevice,
VmUpdateDevice (leading CAP) looks like a class, and I do not see it defined.
Line 1745:                            ('<vmId> <devicespec>',
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

Antoni Segura Puimedon has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 6: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'updateVmDevice': (serv.VmUpdateDevice,
:O That is an ugly typo. I'll fix it straight away! That happens to me for making patches late.
Line 1745:                            ('<vmId> <devicespec>',
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 7: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'vmUpdateDevice': (serv.vmUpdateDevice,
You should decide this is updateVmDevice or vmUpdateDevice   :)
Line 1745:                            ('<vmId> <devicespec>',
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

Antoni Segura Puimedon has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 7: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1740:                         'libvirt-like format. see '
Line 1741:                         'http://libvirt.org/formatdomain.html'
Line 1742:                          '#elementsCPUTuning'
Line 1743:                         )),
Line 1744:         'vmUpdateDevice': (serv.vmUpdateDevice,
:O Bummer! I overlooked the change in 208-210.
Line 1745:                            ('<vmId> <devicespec>',
Line 1746:                             'Update a VM's device',
Line 1747:                             'devicespec parameters list: r=required, '
Line 1748:                             'o=optional',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

ShaoHe Feng has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 8: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 206:         return self.ExecAndExit(self.s.create(params))
Line 207: 
Line 208:     def vmUpdateDevice(self, args):
Line 209:         return self.ExecAndExit(self.s.vmUpdateDevice(args[0],
Line 210:                                                       self._eqSplit(args[1:])))
Yes, it's  good.
More of that I think we'll need to change other functions (hotpug/hotunplug Nic/Disk) to use self._eqSplit
Line 211: 
Line 212:     def hotplugNic(self, args):
Line 213:         nic = self._parseDriveSpec(args[1])
Line 214:         nic['type'] = 'interface'

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/244/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/210/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 9: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/210/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/244/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/213/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/247/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/213/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/247/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1750:                             'devicespec parameters list: r=required, '
Line 1751:                             'o=optional',
Line 1752:                             'r   devicetype: interface',
Line 1753:                             'o   network: network name - No chage if not '
Line 1754:                             'specified. Dummy bridge and link inactive if '
too bad pep8 wants this indentation..
Line 1755:                             'empty string',
Line 1756:                             'o   linkActive: bool - No change if not '
Line 1757:                             'specified',
Line 1758:                             'r   alias: libvirt's vnic alias',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

ShaoHe Feng has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1750:                             'devicespec parameters list: r=required, '
Line 1751:                             'o=optional',
Line 1752:                             'r   devicetype: interface',
Line 1753:                             'o   network: network name - No chage if not '
Line 1754:                             'specified. Dummy bridge and link inactive if '
I think a good way for this patch, first fix all the pep8 of this file, and then submit a new patch based on the peps fixed patch.
Line 1755:                             'empty string',
Line 1756:                             'o   linkActive: bool - No change if not '
Line 1757:                             'specified',
Line 1758:                             'r   alias: libvirt's vnic alias',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1750:                             'devicespec parameters list: r=required, '
Line 1751:                             'o=optional',
Line 1752:                             'r   devicetype: interface',
Line 1753:                             'o   network: network name - No chage if not '
Line 1754:                             'specified. Dummy bridge and link inactive if '
ShaoHe, I do not understand your request. In my opinion, pep8 fixes are asynchronous to the general development.
Line 1755:                             'empty string',
Line 1756:                             'o   linkActive: bool - No change if not '
Line 1757:                             'specified',
Line 1758:                             'r   alias: libvirt's vnic alias',

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/280/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/246/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 11: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/246/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/280/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

Patch Set 11: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................

netwiring: [3/4] Add cli entry point.

Third of the Network Wiring feature patches. It adds the cli support
for using the new vmUpdateDevice feature.

Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Signed-off-by: Antoni S. Puimedon 
---
M vdsm_cli/vdsClient.py
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

Objections:
  oVirt Jenkins CI Server: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server