Change in vdsm[master]: vdsm: storage/task.py replace/remove too generic except hand...

[Vinzenz Feenstra]

Vinzenz Feenstra has uploaded a new change for review.

Change subject: vdsm: storage/task.py replace/remove too generic except handlers
......................................................................

vdsm: storage/task.py replace/remove too generic except handlers

Change-Id: Ia09dcada40bca3f16f94ad7a6c83e6d7a85ade77
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
---
M vdsm/storage/task.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/17751/1

diff --git a/vdsm/storage/task.py b/vdsm/storage/task.py
index 4eff5c1..5b8613f 100644
--- a/vdsm/storage/task.py
+++ b/vdsm/storage/task.py
@@ -173,7 +173,7 @@
                 self.state = self.unknown
             else:
                 self.state = getattr(self, state)
-        except:
+        except AttributeError:
             self.state = self.unknown
 
     def value(self):
@@ -751,7 +751,7 @@
             self.log.error("Unexpected error", exc_info=True)
             try:
                 getProcPool().fileUtils.cleanupdir(taskDir)
-            except:
+            except Exception:
                 self.log.warning("can't remove temp taskdir %s" % taskDir)
             raise se.TaskPersistError("%s persist failed: %s" % (self, e))
         # Make sure backup dir doesn't exist
@@ -862,8 +862,6 @@
         except Exception as e:
             message = unicode(e)
             self._setError(e)
-        except:
-            self._setError()
 
         self.log.debug("Task._run: %s %s %s failed - stopping task",
                        self, args, kargs)


-- 
To view, visit http://gerrit.ovirt.org/17751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia09dcada40bca3f16f94ad7a6c83e6d7a85ade77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;