From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Introducing firewalld configurator
......................................................................
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/74883/25/lib/vdsm/tool/configurators/firewal...
File lib/vdsm/tool/configurators/firewalld.py:
PS25, Line 36: investigate
please add a ref to
http://lists.ovirt.org/pipermail/devel/2017-April/030074.html
I simply want this file to hold all that we know and all we need to know about firewalld
configuration.
Line 35:
Line 36: # TODO: investigate/add missing ports/services
Line 37: #
Line 38: # virt:
Line 39: # serial consoles (tcp/2223)
please add ovirt-imageio and a url to your pull-request
Line 40: # ovn host tunnels (udp/6081)
Line 41: #
Line 42: # gluster:
Line 43: # gluster swift (tcp/8080)
--
To view, visit
https://gerrit.ovirt.org/74883
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b5f533de0b609c15a2482b2fba0ae713c3c33
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes