[NEW PATCH] BZ#736034 - Add metadataignore switch to pvcreate. (via gerrit-bot)

New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/908

commit 68353143d2d26a0f1e6e24e972e85970b9c17c23
Author: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Date:   Wed Sep 7 14:00:04 2011 +0300

    BZ#736034 - Add metadataignore switch to pvcreate.
    
    Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 921cf3b..7550728 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -707,7 +707,7 @@ def _initpv(device, metadataSize=0):
         metadatasize = str(metadataSize) + 'm'
         cmd = ["pvcreate", "--metadatasize", metadatasize, device]
     else:
-        cmd = ["pvcreate", "--pvmetadatacopies", "0",
device]
+        cmd = ["pvcreate", "--pvmetadatacopies", "0",
"--metadataignore", "y", device]
 
     #pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
     #The device is created with the new parameters.

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

Eduardo Warszawski has abandoned this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 9: Abandoned

Submited to Ovirt

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 9: Verified

- tested createVG flow
- tested extendVG flow

fix set a place holder in other PVs, which allows, if needed, to perform manual pvmove
between old pv and new one.
also note that if vgcreate command is sent with N devices, then we use only one pvcreate
command with list of pvs and not pvcreate command for each pv like we used to (great scale
improvement)

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 9: I would prefer that you didn't submit this

requires a proper backport message, with downstream BZ and all.

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 8: Fails

still fails. Edu has all data.

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

typo in BZ#736034 - Add metadataignore switch to pvcreate.

[Dan Kenigsberg]

On Mon, Sep 19, 2011 at 02:16:07PM +0300, Haim Ateya wrote:
>  Haim Ateya has posted comments on this change.
>  
>  Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
>  ......................................................................
>  
>  
>  Patch Set 4: Fails
>  
>  (1 inline comment)
>  
>  please fix metdacopies to metadatacopies.
>  
>  ....................................................
>  File vdsm/storage/lvm.py
>  Line 704: def _initpvs(devices, metadataSize):
>  Line 705:     devices = _normalizeargs(devices)
>  Line 706:     # Size for pvcreate should be with units k|m|g
>  Line 707:     metadatasize = str(metadataSize) + 'm'
>  Line 708:     cmd = ["pvcreate", "--metadatasize", metadatasize,
> "metadacopies", "2", "--metadataignore"]
>  should be "metadatacopies" and not "metadacopies".
>  Line 709:     cmd.extend(devices)
>  Line 710: 
>  Line 711:     #pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
>  Line 712:     #The device is created with the new parameters. 
Thanks for noticing this. If you fix this typo, does the patch deliver
its promisses?

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 4: Fails

(1 inline comment)

please fix metdacopies to metadatacopies.

....................................................
File vdsm/storage/lvm.py
Line 704: def _initpvs(devices, metadataSize):
Line 705:     devices = _normalizeargs(devices)
Line 706:     # Size for pvcreate should be with units k|m|g
Line 707:     metadatasize = str(metadataSize) + 'm'
Line 708:     cmd = ["pvcreate", "--metadatasize", metadatasize,
"metadacopies", "2", "--metadataignore"]
should be "metadatacopies" and not "metadacopies".
Line 709:     cmd.extend(devices)
Line 710: 
Line 711:     #pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
Line 712:     #The device is created with the new parameters.


--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

Saggi Mizrahi has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;