Change in vdsm[master]: build: check-patch.el7 does not require py3

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has uploaded a new change for review.

Change subject: build: check-patch.el7 does not require py3
......................................................................

build: check-patch.el7 does not require py3

We do not run py3 tests on el7, so we should not pull the related
packages.

Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M automation/check-patch.packages.el7
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/66246/1

diff --git a/automation/check-patch.packages.el7 b/automation/check-patch.packages.el7
index bfb21e4..937f0ea 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -20,9 +20,6 @@
 python-rtslib
 python-setuptools
 python-six
-python34-nose
-python34-six
-python34
 rpm-build
 sanlock-python
 sudo


-- 
To view, visit https://gerrit.ovirt.org/66246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

Change in vdsm[master]: automation: check-patch.el7 does not require py3

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: check-patch.el7 does not require py3
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/66246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Change in vdsm[master]: automation: check-patch.el7 does not require py3

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: automation: check-patch.el7 does not require py3
......................................................................


Patch Set 2: Code-Review+2 Verified+1

still passes CI

-- 
To view, visit https://gerrit.ovirt.org/66246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Change in vdsm[master]: automation: check-patch.el7 does not require py3

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: automation: check-patch.el7 does not require py3
......................................................................


automation: check-patch.el7 does not require py3

We do not run py3 tests on el7, so we should not pull the related
packages.

Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/66246
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M automation/check-patch.packages.el7
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/66246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;