2:17 a.m.
Hello Adam Litke,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42968
to review the following change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Balloon should not work when guest agent is not present
StatAvg returns 0 when there is no data available. We need to use Stat
here so we get None and properly fail the condition.
Change-Id: Ic164043259a2936243e572c14705afa064f92171
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232669
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42207
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke(a)redhat.com>
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/42968/1
diff --git a/vdsm/mom.d/02-balloon.policy b/vdsm/mom.d/02-balloon.policy
index 570c751..b1af0d5 100644
--- a/vdsm/mom.d/02-balloon.policy
+++ b/vdsm/mom.d/02-balloon.policy
@@ -116,7 +116,7 @@
})
(with Guests guest
- (if (valid guest.balloon_cur (guest.StatAvg "mem_unused"))
+ (if (valid guest.balloon_cur (guest.Stat "mem_unused"))
(balloon_logic guest)
(debug "Memory information is missing, ballooning for" guest
"disabled")))
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
2:18 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 1:
* Update tracker::#1232669::OK
* Check Bug-Url::OK
* Check Public Bug::#1232669::OK, public bug
* Check Product::#1232669::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1232669::OK, correct target release 3.5.4
* Check merged to previous::OK, change not open on any previous branch
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:18 a.m.
Martin Sivák has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:27 a.m.
Roy Golan has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:09 a.m.
Adam Litke has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:46 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 2:
* Update tracker::#1232669::OK
* Check Bug-Url::OK
* Check Public Bug::#1232669::OK, public bug
* Check Product::#1232669::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1232669::OK, correct target release 3.5.4
* Check merged to previous::OK, change not open on any previous branch
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
6:35 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
6:35 a.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Balloon should not work when guest agent is not present
StatAvg returns 0 when there is no data available. We need to use Stat
here so we get None and properly fail the condition.
Change-Id: Ic164043259a2936243e572c14705afa064f92171
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232669
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42207
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42968
Reviewed-by: Roy Golan <rgolan(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Martin Sivák: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
6:35 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
......................................................................
Patch Set 3:
* Update tracker::#1232669::OK
* Set MODIFIED::bug 1232669::::#1232669::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3015
days inactive
3017
days old
vdsm-patches@lists.fedorahosted.org
8 comments
5 participants
participants (5)
-
alitke＠redhat.com -
automation＠ovirt.org -
Martin Sivak -
Roy Golan -
ybronhei＠redhat.com