Change in vdsm[ovirt-3.5]: Balloon should not work when guest agent is not present

[Martin Sivak]

Hello Adam Litke,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/42968

to review the following change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Balloon should not work when guest agent is not present

StatAvg returns 0 when there is no data available. We need to use Stat
here so we get None and properly fail the condition.

Change-Id: Ic164043259a2936243e572c14705afa064f92171
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232669
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/42207
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/42968/1

diff --git a/vdsm/mom.d/02-balloon.policy b/vdsm/mom.d/02-balloon.policy
index 570c751..b1af0d5 100644
--- a/vdsm/mom.d/02-balloon.policy
+++ b/vdsm/mom.d/02-balloon.policy
@@ -116,7 +116,7 @@
 })

(with Guests guest
-    (if (valid guest.balloon_cur (guest.StatAvg "mem_unused"))
+    (if (valid guest.balloon_cur (guest.Stat "mem_unused"))
         (balloon_logic guest)
         (debug "Memory information is missing, ballooning for" guest "disabled")))

[e-mail] has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 1:

* Update tracker::#1232669::OK
* Check Bug-Url::OK
* Check Public Bug::#1232669::OK, public bug
* Check Product::#1232669::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1232669::OK, correct target release 3.5.4
* Check merged to previous::OK, change not open on any previous branch

[Martin Sivak]

Martin Sivák has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 1: Verified+1

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 1: Code-Review+1

Adam Litke has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 1: Code-Review+1

[e-mail] has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 2:

* Update tracker::#1232669::OK
* Check Bug-Url::OK
* Check Public Bug::#1232669::OK, public bug
* Check Product::#1232669::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1232669::OK, correct target release 3.5.4
* Check merged to previous::OK, change not open on any previous branch

Yaniv Bronhaim has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 2: Code-Review+2

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Balloon should not work when guest agent is not present

StatAvg returns 0 when there is no data available. We need to use Stat
here so we get None and properly fail the condition.

Change-Id: Ic164043259a2936243e572c14705afa064f92171
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232669
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/42207
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/42968
Reviewed-by: Roy Golan 
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Martin Sivák: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, but someone else must approve

[e-mail] has posted comments on this change.

Change subject: Balloon should not work when guest agent is not present
......................................................................

Patch Set 3:

* Update tracker::#1232669::OK
* Set MODIFIED::bug 1232669::::#1232669::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager