Dan Kenigsberg has submitted this change and it was merged.
Change subject: setNumberOfCpus marshalling issue
......................................................................
setNumberOfCpus marshalling issue
xmlrpc uses vmID twice to construct VM object and to run setNumberOfCpus.
In xmlrpc we provide implementation how we instantiate API object and
invoke a verb so we do not care how the parameters are used.
Whereas in jsonrpc we use "reflection" so we can't use the same parameter
twice.
Bug-Url:
https://bugzilla.redhat.com/1138181
Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-on:
http://gerrit.ovirt.org/32414
Reviewed-by: Roy Golan <rgolan(a)redhat.com>
Tested-by: Omer Frenkel <ofrenkel(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Roy Golan: Looks good to me, but someone else must approve
Omer Frenkel: Verified
--
To view, visit
http://gerrit.ovirt.org/32414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server